Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(637)

Issue 2777183009: Revert of Bug Fix: Data Race For WebMediaPlayerMS' Frame Count Variable (Closed)

Created:
3 years, 8 months ago by qiangchen
Modified:
3 years, 8 months ago
Reviewers:
DaleCurtis
CC:
chfremer+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, mcasas+watch+vc_chromium.org, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Bug Fix: Data Race For WebMediaPlayerMS' Frame Count Variable (patchset #3 id:60001 of https://codereview.chromium.org/2751353003/ ) Reason for revert: Lock contention, increase chrome_public_test_apk run time a lot. We might need a finer lock. Original issue's description: > Bug Fix: Data Race For WebMediaPlayerMS' Frame Count Variable > > On thread sanitizer, we found a data race issue for WebMediaPlayerMS' frame > count variables |total_frame_count_| and |dropped_frame_count_|. In this CL > We make those two variables atomic. > > BUG=701712 > > Review-Url: https://codereview.chromium.org/2751353003 > Cr-Commit-Position: refs/heads/master@{#457786} > Committed: https://chromium.googlesource.com/chromium/src/+/4cb6dcab2e3d9b4f14ff3bd5dc8f3fd3a57e19e5 TBR=dalecurtis@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=701712 Review-Url: https://codereview.chromium.org/2777183009 Cr-Commit-Position: refs/heads/master@{#460556} Committed: https://chromium.googlesource.com/chromium/src/+/5591e262e49dfbf3f23ad6e54717e9dcd2771fe3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M content/renderer/media/webmediaplayer_ms_compositor.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/media/webmediaplayer_ms_compositor.cc View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
qiangchen
Created Revert of Bug Fix: Data Race For WebMediaPlayerMS' Frame Count Variable
3 years, 8 months ago (2017-03-29 21:02:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2777183009/1
3 years, 8 months ago (2017-03-29 21:03:43 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/5591e262e49dfbf3f23ad6e54717e9dcd2771fe3
3 years, 8 months ago (2017-03-29 22:34:34 UTC) #6
qiangchen
3 years, 8 months ago (2017-03-31 23:04:12 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2789973002/ by qiangchen@chromium.org.

The reason for reverting is: By testing, this CL is not the cause of increase of
chrome_public_test_apk run time..

Powered by Google App Engine
This is Rietveld 408576698