Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2751353003:
Bug Fix: Data Race For WebMediaPlayerMS' Frame Count Variable (Closed)
|
Created:
3 years, 9 months ago by qiangchen Modified:
3 years, 9 months ago Reviewers:
DaleCurtis CC:
chfremer+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, mcasas+watch+vc_chromium.org, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionBug Fix: Data Race For WebMediaPlayerMS' Frame Count Variable
On thread sanitizer, we found a data race issue for WebMediaPlayerMS' frame
count variables |total_frame_count_| and |dropped_frame_count_|. In this CL
We make those two variables atomic.
BUG=701712
Review-Url: https://codereview.chromium.org/2751353003
Cr-Commit-Position: refs/heads/master@{#457786}
Committed: https://chromium.googlesource.com/chromium/src/+/4cb6dcab2e3d9b4f14ff3bd5dc8f3fd3a57e19e5
Patch Set 1 : include #Patch Set 2 : Lock #Patch Set 3 : Remove const #
Messages
Total messages: 33 (21 generated)
Description was changed from ========== Bug Fix: Data Race For WebMediaPlayerMS' Frame Count Variable BUG=701712 ========== to ========== Bug Fix: Data Race For WebMediaPlayerMS' Frame Count Variable On thread sanitizer, we found a data race issue for WebMediaPlayerMS' frame count variables |total_frame_count_| and |dropped_frame_count_|. In this CL We make those two variables atomic. BUG=701712 ==========
The CQ bit was checked by qiangchen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by qiangchen@chromium.org to run a CQ dry run
Patchset #1 (id:1) has been deleted
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
qiangchen@chromium.org changed reviewers: + dalecurtis@chromium.org
Can you take a look at this simple fix?
Can't use std atomic per style guide. Just set them under lock.
Then we can use current_frame_lock_, as these two quantities are related to frame updating.
lgtm
The CQ bit was checked by qiangchen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Hmm, Render() doesn't seem to hold current_Frame_lock?
Nevermind it asserts acquired.
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
The CQ bit was checked by qiangchen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by qiangchen@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dalecurtis@chromium.org Link to the patchset: https://codereview.chromium.org/2751353003/#ps60001 (title: "Remove const")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1489766443703530,
"parent_rev": "db135527d8e98d22bbd95f3d9f79ad2d7ea9fc7e", "commit_rev":
"4cb6dcab2e3d9b4f14ff3bd5dc8f3fd3a57e19e5"}
Message was sent while issue was closed.
Description was changed from ========== Bug Fix: Data Race For WebMediaPlayerMS' Frame Count Variable On thread sanitizer, we found a data race issue for WebMediaPlayerMS' frame count variables |total_frame_count_| and |dropped_frame_count_|. In this CL We make those two variables atomic. BUG=701712 ========== to ========== Bug Fix: Data Race For WebMediaPlayerMS' Frame Count Variable On thread sanitizer, we found a data race issue for WebMediaPlayerMS' frame count variables |total_frame_count_| and |dropped_frame_count_|. In this CL We make those two variables atomic. BUG=701712 Review-Url: https://codereview.chromium.org/2751353003 Cr-Commit-Position: refs/heads/master@{#457786} Committed: https://chromium.googlesource.com/chromium/src/+/4cb6dcab2e3d9b4f14ff3bd5dc8f... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as https://chromium.googlesource.com/chromium/src/+/4cb6dcab2e3d9b4f14ff3bd5dc8f...
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:60001) has been created in https://codereview.chromium.org/2777183009/ by qiangchen@chromium.org. The reason for reverting is: Lock contention, increase chrome_public_test_apk run time a lot. We might need a finer lock..
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:60001) has been created in https://codereview.chromium.org/2783013002/ by hzl@google.com. The reason for reverting is: Reverting the cl to see whether lock contention has increased chrome public test apk time. Thanks qiangchen for understanding!. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
