setValueCurveAtTime takes sequence<float> for curve

setValueCurveAtTime takes sequence<float> for curve

Instead of a Float32Array, the curve parameter for an
AudioParam.setValueCurveAtTime method is now a sequence<float>.  This
also implies that only finite values for the curve.

This change is (mostly) backward compatible since Float32Array is a
sequence<float>.

Added a test to verify that we throw an error if the curve contains a
non-finite value.

BUG=708306
TEST=AudioParam/audioparam-exceptional-values.html

Review-Url: https://codereview.chromium.org/2789883002
Cr-Commit-Position: refs/heads/master@{#464504}
Committed: https://chromium.googlesource.com/chromium/src/+/e78f7c1cc5587c0a09ca68b9519a45b1c3238ece

[Raymond Toy, 2017-04-04 21:23:06]

Description was changed from

==========
setValueCurveAtTime takes sequence<float> for curve

Instead of a Float32Array, the curve parameter for an
AudioParam.setValueCurveAtTime method is now a sequence<float>.  This
also implies that only finite values for the curve.

This change is backward compatible sine Float32Array is a
sequence<float>.

Added a test to verify that we throw an error if the curve contains a
non-finite value.

BUG=
TEST=AudioParam/audioparam-exceptional-values.html
==========

to

==========
setValueCurveAtTime takes sequence<float> for curve

Instead of a Float32Array, the curve parameter for an
AudioParam.setValueCurveAtTime method is now a sequence<float>.  This
also implies that only finite values for the curve.

This change is backward compatible sine Float32Array is a
sequence<float>.

Added a test to verify that we throw an error if the curve contains a
non-finite value.

BUG=708306
TEST=AudioParam/audioparam-exceptional-values.html
==========

[Raymond Toy, 2017-04-11 15:01:45]

Description was changed from

==========
setValueCurveAtTime takes sequence<float> for curve

Instead of a Float32Array, the curve parameter for an
AudioParam.setValueCurveAtTime method is now a sequence<float>.  This
also implies that only finite values for the curve.

This change is backward compatible sine Float32Array is a
sequence<float>.

Added a test to verify that we throw an error if the curve contains a
non-finite value.

BUG=708306
TEST=AudioParam/audioparam-exceptional-values.html
==========

to

==========
setValueCurveAtTime takes sequence<float> for curve

Instead of a Float32Array, the curve parameter for an
AudioParam.setValueCurveAtTime method is now a sequence<float>.  This
also implies that only finite values for the curve.

This change is (mostly) backward compatible since Float32Array is a
sequence<float>.

Added a test to verify that we throw an error if the curve contains a
non-finite value.

BUG=708306
TEST=AudioParam/audioparam-exceptional-values.html
==========

[Raymond Toy, 2017-04-11 15:04:02]

rtoy@chromium.org changed reviewers:
+ hongchan@chromium.org

[Raymond Toy, 2017-04-11 15:04:02]

PTAL.  The spec issue is finalized

[hongchan, 2017-04-11 17:12:24]

lgtm with nit

https://codereview.chromium.org/2789883002/diff/100001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-exceptional-values.html
(right):

https://codereview.chromium.org/2789883002/diff/100001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-exceptional-values.html:109:
// Non-finite curve values should signal an error
super nit: a period at the end.

[Raymond Toy, 2017-04-11 20:11:00]

https://codereview.chromium.org/2789883002/diff/100001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-exceptional-values.html
(right):

https://codereview.chromium.org/2789883002/diff/100001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-exceptional-values.html:109:
// Non-finite curve values should signal an error
On 2017/04/11 17:12:24, hongchan wrote:
> super nit: a period at the end.

Done.

[Raymond Toy, 2017-04-11 20:12:33]

rtoy@chromium.org changed reviewers:
+ tkent@chromium.org

[Raymond Toy, 2017-04-11 20:12:33]

PTAL.  This is a minor API change where we use sequence<float> instead of
Float32Array now.

I didn't write an intent for this.  For most users, the change is transparent,
unless they were using non-finite values for the curve.

[tkent, 2017-04-12 13:46:07]

On 2017/04/11 at 20:12:33, rtoy wrote:
> PTAL.  This is a minor API change where we use sequence<float> instead of
Float32Array now.
> 
> I didn't write an intent for this.  For most users, the change is transparent,
unless they were using non-finite values for the curve.

It sounds reasonable.  lgtm

[Raymond Toy, 2017-04-12 15:08:57]

The CQ bit was checked by rtoy@chromium.org

[Raymond Toy, 2017-04-12 15:08:57]

The patchset sent to the CQ was uploaded after l-g-t-m from
hongchan@chromium.org
Link to the patchset: https://codereview.chromium.org/2789883002/#ps120001
(title: "Address review comments")

[commit-bot: I haz the power, 2017-04-12 15:09:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 15:13:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 15:13:05]

Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Raymond Toy, 2017-04-12 15:32:32]

The CQ bit was checked by rtoy@chromium.org

[Raymond Toy, 2017-04-12 15:32:33]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org,
hongchan@chromium.org
Link to the patchset: https://codereview.chromium.org/2789883002/#ps140001
(title: "Rebase")

[commit-bot: I haz the power, 2017-04-12 15:33:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 17:04:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 17:04:25]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Raymond Toy, 2017-04-12 18:11:51]

The CQ bit was checked by rtoy@chromium.org

[Raymond Toy, 2017-04-12 18:11:51]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org,
hongchan@chromium.org
Link to the patchset: https://codereview.chromium.org/2789883002/#ps160001
(title: "Rebaseline test result")

[commit-bot: I haz the power, 2017-04-12 18:13:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 19:55:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 19:55:29]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Raymond Toy, 2017-04-13 15:17:04]

The CQ bit was checked by rtoy@chromium.org

[Raymond Toy, 2017-04-13 15:17:04]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org,
hongchan@chromium.org
Link to the patchset: https://codereview.chromium.org/2789883002/#ps220001
(title: "Remove SharedArrayBuffer test; rebaseline results")

[commit-bot: I haz the power, 2017-04-13 15:17:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 16:47:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 16:47:59]

Failed to apply patch for
third_party/WebKit/LayoutTests/virtual/sharedarraybuffer/webaudio/dom-exceptions-expected.txt:
While running git apply --index -3 -p1;
  <stdin>:24: trailing whitespace.
  PASS   param.setValueCurveAtTime(null, 0, 0) threw TypeError: "Failed to
execute 'setValueCurveAtTime' on 'AudioParam': The 1st argument is neither an
array, nor does it have indexed properties.". 
  <stdin>:31: trailing whitespace.
  PASS < [audioparam] All assertions passed. (total 6 assertions) 
  error: patch failed:
third_party/WebKit/LayoutTests/virtual/sharedarraybuffer/webaudio/dom-exceptions-expected.txt:1
  Falling back to three-way merge...
  Applied patch to
'third_party/WebKit/LayoutTests/virtual/sharedarraybuffer/webaudio/dom-exceptions-expected.txt'
with conflicts.
  U
third_party/WebKit/LayoutTests/virtual/sharedarraybuffer/webaudio/dom-exceptions-expected.txt
  warning: 2 lines add whitespace errors.

Patch:      
third_party/WebKit/LayoutTests/virtual/sharedarraybuffer/webaudio/dom-exceptions-expected.txt
Index:
third_party/WebKit/LayoutTests/virtual/sharedarraybuffer/webaudio/dom-exceptions-expected.txt
diff --git
a/third_party/WebKit/LayoutTests/virtual/sharedarraybuffer/webaudio/dom-exceptions-expected.txt
b/third_party/WebKit/LayoutTests/virtual/sharedarraybuffer/webaudio/dom-exceptions-expected.txt
index
82728fbee9cfc20acf485ab48a2d28a70b9a93be..f2a49d27a7094cdf807f5fc05ac582d08a15f9ee
100644
---
a/third_party/WebKit/LayoutTests/virtual/sharedarraybuffer/webaudio/dom-exceptions-expected.txt
+++
b/third_party/WebKit/LayoutTests/virtual/sharedarraybuffer/webaudio/dom-exceptions-expected.txt
@@ -1,8 +1,8 @@
 CONSOLE WARNING: line 341: The provided value 'fancy' is not a valid enum value
of type ChannelCountMode.
 CONSOLE WARNING: line 347: The provided value 'undefined' is not a valid enum
value of type ChannelInterpretation.
-CONSOLE WARNING: line 502: The provided value '9x' is not a valid enum value of
type OverSampleType.
-CONSOLE WARNING: line 717: The provided value 'junk' is not a valid enum value
of type ChannelCountMode.
-CONSOLE WARNING: line 746: The provided value 'junk' is not a valid enum value
of type ChannelCountMode.
+CONSOLE WARNING: line 495: The provided value '9x' is not a valid enum value of
type OverSampleType.
+CONSOLE WARNING: line 710: The provided value 'junk' is not a valid enum value
of type ChannelCountMode.
+CONSOLE WARNING: line 739: The provided value 'junk' is not a valid enum value
of type ChannelCountMode.
 This is a testharness.js-based test.
 PASS # AUDIT TASK RUNNER STARTED. 
 PASS > [initialize] Initialize contexts for testing 
@@ -105,14 +105,13 @@ PASS   node.channelInterpretation is equal to speakers.
 PASS   context.destination.channelCount = 99 threw IndexSizeError: [error
message omitted]. 
 PASS < [channel-stuff] All assertions passed. (total 7 assertions) 
 PASS > [audioparam]  
-PASS   param.setValueCurveAtTime(null, 0, 0) threw TypeError: "Failed to
execute 'setValueCurveAtTime' on 'AudioParam': parameter 1 is not of type
'Float32Array'.". 
-PASS   param.setValueCurveAtTime(SharedArrayBuffer view, 0, 0) threw TypeError:
"Failed to execute 'setValueCurveAtTime' on 'AudioParam': The provided
ArrayBufferView value must not be shared.". 
+PASS   param.setValueCurveAtTime(null, 0, 0) threw TypeError: "Failed to
execute 'setValueCurveAtTime' on 'AudioParam': The 1st argument is neither an
array, nor does it have indexed properties.". 
 PASS   node.gain.exponentialRampToValueAtTime(-1, 0.1) did not throw an
exception. 
 PASS   node.gain.exponentialRampToValueAtTime(0, 0.1) threw InvalidAccessError:
"Failed to execute 'exponentialRampToValueAtTime' on 'AudioParam': The float
target value provided (0) should not be in the range (-1.40130e-45,
1.40130e-45).". 
 PASS   node.gain.exponentialRampToValueAtTime(1e-100, 0.1) threw
InvalidAccessError: "Failed to execute 'exponentialRampToValueAtTime' on
'AudioParam': The float target value provided (0) should not be in the range
(-1.40130e-45, 1.40130e-45).". 
 PASS   node.gain.exponentialRampToValueAtTime(Math.pow(2, -149), 0.1) did not
throw an exception. 
 PASS   node.gain.exponentialRampToValueAtTime(Math.pow(2, -150), 0.1) threw
InvalidAccessError: "Failed to execute 'exponentialRampToValueAtTime' on
'AudioParam': The float target value provided (0) should not be in the range
(-1.40130e-45, 1.40130e-45).". 
-PASS < [audioparam] All assertions passed. (total 7 assertions) 
+PASS < [audioparam] All assertions passed. (total 6 assertions) 
 PASS > [biquad]  
 PASS   node.getFrequencyResponse(new Float32Array(1), new Float32Array(1), new
Float32Array(1)) did not throw an exception. 
 PASS   node.getFrequencyResponse(null, new Float32Array(1), new
Float32Array(1)) threw TypeError: "Failed to execute 'getFrequencyResponse' on
'BiquadFilterNode': parameter 1 is not of type 'Float32Array'.".

[Raymond Toy, 2017-04-13 17:55:42]

The CQ bit was checked by rtoy@chromium.org

[Raymond Toy, 2017-04-13 17:55:42]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org,
hongchan@chromium.org
Link to the patchset: https://codereview.chromium.org/2789883002/#ps240001
(title: "Rebaseline test results")

[commit-bot: I haz the power, 2017-04-13 17:56:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 19:31:39]

CQ is committing da patch.

Bot data: {"patchset_id": 240001, "attempt_start_ts": 1492106142223950,
"parent_rev": "16616a21c2ed290d72aba2e90cabf1c50799cebd", "commit_rev":
"e78f7c1cc5587c0a09ca68b9519a45b1c3238ece"}

[commit-bot: I haz the power, 2017-04-13 19:43:32]

Description was changed from

==========
setValueCurveAtTime takes sequence<float> for curve

Instead of a Float32Array, the curve parameter for an
AudioParam.setValueCurveAtTime method is now a sequence<float>.  This
also implies that only finite values for the curve.

This change is (mostly) backward compatible since Float32Array is a
sequence<float>.

Added a test to verify that we throw an error if the curve contains a
non-finite value.

BUG=708306
TEST=AudioParam/audioparam-exceptional-values.html
==========

to

==========
setValueCurveAtTime takes sequence<float> for curve

Instead of a Float32Array, the curve parameter for an
AudioParam.setValueCurveAtTime method is now a sequence<float>.  This
also implies that only finite values for the curve.

This change is (mostly) backward compatible since Float32Array is a
sequence<float>.

Added a test to verify that we throw an error if the curve contains a
non-finite value.

BUG=708306
TEST=AudioParam/audioparam-exceptional-values.html

Review-Url: https://codereview.chromium.org/2789883002
Cr-Commit-Position: refs/heads/master@{#464504}
Committed:
https://chromium.googlesource.com/chromium/src/+/e78f7c1cc5587c0a09ca68b9519a...
==========

[commit-bot: I haz the power, 2017-04-13 19:43:33]

Committed patchset #13 (id:240001) as
https://chromium.googlesource.com/chromium/src/+/e78f7c1cc5587c0a09ca68b9519a...