third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-exceptional-values.html - Issue 2789883002: setValueCurveAtTime takes sequence<float> for curve

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-exceptional-values.html

Issue 2789883002: setValueCurveAtTime takes sequence<float> for curve (Closed)

Patch Set: Use references; fix merge mistake. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">	1 <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">

2 <html>	2 <html>

3 <head>	3 <head>

4 <script src="../../resources/testharness.js"></script>	4 <script src="../../resources/testharness.js"></script>

5 <script src="../../resources/testharnessreport.js"></script>	5 <script src="../../resources/testharnessreport.js"></script>

6 <script src="../resources/audit-util.js"></script>	6 <script src="../resources/audit-util.js"></script>

7 <script src="../resources/audit.js"></script>	7 <script src="../resources/audit.js"></script>

8 </head>	8 </head>

9	9

10 <body>	10 <body>

(...skipping 88 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
99 () => gain.gain.setValueCurveAtTime(curve, startTime, 1),	99 () => gain.gain.setValueCurveAtTime(curve, startTime, 1),

100 'gain.gain.setValueCurveAtTime(curve, ' + startTime + ', 1)')	100 'gain.gain.setValueCurveAtTime(curve, ' + startTime + ', 1)')

101 .throw();	101 .throw();

102 }	102 }

103 for (duration of durationValues) {	103 for (duration of durationValues) {

104 should(	104 should(

105 () => gain.gain.setValueCurveAtTime(curve, 1, duration),	105 () => gain.gain.setValueCurveAtTime(curve, 1, duration),

106 'gain.gain.setValueCurveAtTime(curve, 1, ' + duration + ')')	106 'gain.gain.setValueCurveAtTime(curve, 1, ' + duration + ')')

107 .throw();	107 .throw();

108 }	108 }

109	109 // Non-finite curve values should signal an error
	hongchan 2017/04/11 17:12:24 super nit: a period at the end. super nit: a period at the end. Raymond Toy 2017/04/11 20:11:00 Done. Show quoted text On 2017/04/11 17:12:24, hongchan wrote: > super nit: a period at the end. Done.
	110 for (curve of [[1, 2, Infinity, 3], [1, NaN, 2, 3]]) {

	111 should(

	112 () => gain.gain.setValueCurveAtTime(curve, 1, 1),

	113 'gain.gain.setValueCurveAtTime([' + curve + '], 1, 1)')

	114 .throw();

	115 }

110 task.done();	116 task.done();

111 });	117 });

112	118

113 audit.run();	119 audit.run();

114 </script>	120 </script>

115 </body>	121 </body>

116 </html>	122 </html>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-setValueCurve-exceptions-expected.txt » ('j') | no next file with comments »