third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.h - Issue 2789883002: setValueCurveAtTime takes sequence<float> for curve

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.h

Issue 2789883002: setValueCurveAtTime takes sequence<float> for curve (Closed)

Patch Set: Rebaseline test results Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.h

diff --git a/third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.h b/third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.h

index f21962c3a96f8e973ff6a9dd7fb4b0472bd5c73d..282549f81cd767091e27aa7d587b338a638fe352 100644

--- a/third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.h

+++ b/third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.h

@@ -61,7 +61,7 @@ class AudioParamTimeline {

double time,

double time_constant,

ExceptionState&);

- void SetValueCurveAtTime(DOMFloat32Array* curve,

+ void SetValueCurveAtTime(const Vector<float>& curve,

double time,

double duration,

ExceptionState&);

@@ -128,7 +128,7 @@ class AudioParamTimeline {

static std::unique_ptr<ParamEvent>

CreateSetTargetEvent(float value, double time, double time_constant);

static std::unique_ptr<ParamEvent> CreateSetValueCurveEvent(

- const DOMFloat32Array* curve,

+ const Vector<float>& curve,

double time,

double duration);

static std::unique_ptr<ParamEvent> CreateCancelValuesEvent(

@@ -210,7 +210,7 @@ class AudioParamTimeline {

ParamEvent(Type,

double time,

double duration,

- const DOMFloat32Array* curve,

+ const Vector<float>& curve,

double curve_points_per_second,

float curve_end_value);