Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Issue 2771053003: WIP: Plumbing input event latency reporting through Mus GPU.

Created:
3 years, 9 months ago by mfomitchev
Modified:
3 years, 8 months ago
Reviewers:
Fady Samuel
CC:
chromium-reviews, rjkroege, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, dtapuska+chromiumwatch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, yzshen+watch_chromium.org, piman+watch_chromium.org, cc-bugs_chromium.org, darin (slow to review)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

WIP: Plumbing input event latency reporting through Mus GPU. BUG=686865 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Patch Set 1 #

Total comments: 4

Patch Set 2 : Updating dependencies. #

Total comments: 11

Patch Set 3 : Plumb through SetLatencyInfo instead of exposing InProcessCommandBuffer. #

Total comments: 1

Patch Set 4 : Plumbing LatencyInfo through ContextSupport and moving LatencyTracker to ui/latency." #

Patch Set 5 : --similarity 40 #

Patch Set 6 : Move method for ease of review #

Patch Set 7 : Updating TestContextSupport. #

Patch Set 8 : Rebase, renames. #

Patch Set 9 : Cleanup #

Patch Set 10 : Updating tests #

Patch Set 11 : Fixing tests #

Patch Set 12 : Fixing tests #

Patch Set 13 : Fixing tests #

Patch Set 14 : DEPS #

Patch Set 15 : Factoring out latency histograms #

Patch Set 16 : Fixing tests #

Patch Set 17 : --similarity 40 #

Patch Set 18 : --similarity 30 #

Patch Set 19 : --similalrity 20 #

Patch Set 20 : Rebase #

Patch Set 21 : Rebase #

Patch Set 22 : Fixing GTest compile issue on Windows. #

Patch Set 23 : Let's try source_set instead of static_library #

Patch Set 24 : Rebase #

Patch Set 25 : Adding LATENCY_EXPORT #

Patch Set 26 : Rebase #

Patch Set 27 : Rebase #

Patch Set 28 : NON_EXPORTED_BASE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+409 lines, -749 lines) Patch
M cc/surfaces/compositor_frame_sink_support_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 3 chunks +27 lines, -3 lines 0 comments Download
M cc/surfaces/surface_factory.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +8 lines, -0 lines 0 comments Download
M cc/test/test_context_support.h View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -0 lines 0 comments Download
M cc/test/test_context_support.cc View 1 2 3 4 5 6 7 8 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/compositor/gpu_browser_compositor_output_surface.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/DEPS View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/compositor_impl_android.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/render_widget_host_latency_tracker.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 4 chunks +9 lines, -6 lines 0 comments Download
M content/browser/renderer_host/input/render_widget_host_latency_tracker.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 5 chunks +22 lines, -262 lines 0 comments Download
M content/browser/renderer_host/input/render_widget_host_latency_tracker_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 1 chunk +1 line, -2 lines 0 comments Download
M gpu/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +1 line, -0 lines 0 comments Download
A gpu/command_buffer/client/DEPS View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +3 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/client_test_helper.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 2 chunks +2 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/context_support.h View 1 2 3 4 5 6 7 8 2 chunks +9 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation.h View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation.cc View 1 2 3 4 5 6 7 8 1 chunk +5 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gpu_control.h View 1 2 3 4 5 6 7 8 12 2 chunks +9 lines, -0 lines 0 comments Download
M gpu/command_buffer/tests/gl_manager.h View 1 2 3 4 5 6 7 8 9 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/command_buffer/tests/gl_manager.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +3 lines, -0 lines 0 comments Download
M gpu/gles2_conform_support/egl/context.h View 1 2 3 4 5 6 7 8 9 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/gles2_conform_support/egl/context.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +3 lines, -0 lines 0 comments Download
A gpu/ipc/DEPS View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M gpu/ipc/client/command_buffer_proxy_impl.h View 1 2 3 4 5 6 7 8 2 chunks +2 lines, -1 line 0 comments Download
M gpu/ipc/client/command_buffer_proxy_impl.cc View 1 2 3 4 5 6 7 8 2 chunks +7 lines, -7 lines 0 comments Download
M gpu/ipc/in_process_command_buffer.h View 1 2 3 4 5 6 7 8 3 chunks +8 lines, -0 lines 0 comments Download
M gpu/ipc/in_process_command_buffer.cc View 1 2 3 4 5 6 7 8 3 chunks +14 lines, -1 line 0 comments Download
M gpu/ipc/service/pass_through_image_transport_surface.h View 1 2 3 4 5 6 7 8 1 chunk +3 lines, -1 line 0 comments Download
M gpu/ipc/service/pass_through_image_transport_surface.cc View 1 2 3 4 5 6 7 8 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppapi_command_buffer_proxy.h View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -0 lines 0 comments Download
M ppapi/proxy/ppapi_command_buffer_proxy.cc View 1 2 3 4 5 6 7 8 1 chunk +3 lines, -0 lines 0 comments Download
M services/ui/surfaces/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 1 chunk +1 line, -0 lines 0 comments Download
M services/ui/surfaces/DEPS View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 1 chunk +1 line, -0 lines 0 comments Download
M services/ui/surfaces/display_output_surface.h View 1 2 3 3 chunks +4 lines, -1 line 0 comments Download
M services/ui/surfaces/display_output_surface.cc View 1 2 3 4 5 6 7 8 4 chunks +12 lines, -2 lines 0 comments Download
M ui/latency/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 1 chunk +16 lines, -0 lines 0 comments Download
M ui/latency/DEPS View 1 2 3 4 5 6 7 1 chunk +0 lines, -1 line 0 comments Download
A ui/latency/latency_histogram_macros.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +45 lines, -0 lines 0 comments Download
M ui/latency/latency_info.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 4 chunks +18 lines, -3 lines 0 comments Download
M ui/latency/latency_info.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 3 chunks +47 lines, -33 lines 0 comments Download
A ui/latency/latency_info_test_support.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +13 lines, -0 lines 0 comments Download
A ui/latency/latency_tracker.h View 1 2 3 4 5 6 7 8 25 26 27 1 chunk +45 lines, -0 lines 0 comments Download
A + ui/latency/latency_tracker.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 14 chunks +39 lines, -415 lines 0 comments Download
M ui/latency/mojo/latency_info.mojom View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +3 lines, -3 lines 0 comments Download
M ui/latency/mojo/latency_info_struct_traits.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 2 chunks +4 lines, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 91 (86 generated)
mfomitchev
https://codereview.chromium.org/2771053003/diff/1/cc/output/in_process_context_provider.h File cc/output/in_process_context_provider.h (right): https://codereview.chromium.org/2771053003/diff/1/cc/output/in_process_context_provider.h#newcode68 cc/output/in_process_context_provider.h:68: gpu::GLInProcessContext* context() { return context_.get(); } Is this okay? ...
3 years, 9 months ago (2017-03-23 15:09:10 UTC) #6
mfomitchev
https://codereview.chromium.org/2771053003/diff/1/services/ui/surfaces/display_output_surface.cc File services/ui/surfaces/display_output_surface.cc (right): https://codereview.chromium.org/2771053003/diff/1/services/ui/surfaces/display_output_surface.cc#newcode88 services/ui/surfaces/display_output_surface.cc:88: in_process_command_buffer_->SetLatencyInfo(frame.latency_info); This is why I am adding all this ...
3 years, 9 months ago (2017-03-23 15:11:16 UTC) #7
mfomitchev
https://codereview.chromium.org/2771053003/diff/20001/cc/output/in_process_context_provider.h File cc/output/in_process_context_provider.h (right): https://codereview.chromium.org/2771053003/diff/20001/cc/output/in_process_context_provider.h#newcode68 cc/output/in_process_context_provider.h:68: gpu::GLInProcessContext* context() { return context_.get(); } Is this ok? ...
3 years, 9 months ago (2017-03-23 15:25:17 UTC) #12
Fady Samuel
https://codereview.chromium.org/2771053003/diff/20001/cc/output/in_process_context_provider.h File cc/output/in_process_context_provider.h (right): https://codereview.chromium.org/2771053003/diff/20001/cc/output/in_process_context_provider.h#newcode68 cc/output/in_process_context_provider.h:68: gpu::GLInProcessContext* context() { return context_.get(); } On 2017/03/23 15:25:17, ...
3 years, 9 months ago (2017-03-23 17:24:38 UTC) #16
mfomitchev
3 years, 9 months ago (2017-03-24 20:55:58 UTC) #17
https://codereview.chromium.org/2771053003/diff/40001/services/ui/surfaces/di...
File services/ui/surfaces/display_output_surface.h (right):

https://codereview.chromium.org/2771053003/diff/40001/services/ui/surfaces/di...
services/ui/surfaces/display_output_surface.h:59: cc::InProcessContextProvider*
in_process_context_provider() {
How about this?

Powered by Google App Engine
This is Rietveld 408576698