Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2788663003: Document the fact that leveldb sign warnings aren't getting fixed. (Closed)

Created:
3 years, 8 months ago by pwnall
Modified:
3 years, 8 months ago
Reviewers:
cmumford
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Document the fact that leveldb sign warnings aren't getting fixed. BUG=698013 Review-Url: https://codereview.chromium.org/2788663003 Cr-Commit-Position: refs/heads/master@{#460932} Committed: https://chromium.googlesource.com/chromium/src/+/022e76c4e2597f27c442eaecacaabdc708480ff2

Patch Set 1 #

Total comments: 2

Patch Set 2 : Typo fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/leveldatabase/BUILD.gn View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
pwnall
PTAL?
3 years, 8 months ago (2017-03-30 18:13:56 UTC) #4
cmumford
lgtm % typo https://codereview.chromium.org/2788663003/diff/1/third_party/leveldatabase/BUILD.gn File third_party/leveldatabase/BUILD.gn (right): https://codereview.chromium.org/2788663003/diff/1/third_party/leveldatabase/BUILD.gn#newcode134 third_party/leveldatabase/BUILD.gn:134: # leveldb compiles with a limiterd ...
3 years, 8 months ago (2017-03-30 18:15:32 UTC) #6
pwnall
Thank you for the quick review! https://codereview.chromium.org/2788663003/diff/1/third_party/leveldatabase/BUILD.gn File third_party/leveldatabase/BUILD.gn (right): https://codereview.chromium.org/2788663003/diff/1/third_party/leveldatabase/BUILD.gn#newcode134 third_party/leveldatabase/BUILD.gn:134: # leveldb compiles ...
3 years, 8 months ago (2017-03-30 20:38:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2788663003/20001
3 years, 8 months ago (2017-03-30 20:39:41 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-03-30 23:43:02 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/022e76c4e2597f27c442eaecacaa...

Powered by Google App Engine
This is Rietveld 408576698