Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(633)

Unified Diff: third_party/leveldatabase/BUILD.gn

Issue 2788663003: Document the fact that leveldb sign warnings aren't getting fixed. (Closed)
Patch Set: Typo fix. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/leveldatabase/BUILD.gn
diff --git a/third_party/leveldatabase/BUILD.gn b/third_party/leveldatabase/BUILD.gn
index 49a609361912ce5407cec6a33c0fa3c9e3c0a524..be2b0bb48bfa8d75f51238e49977fc418e01c4e4 100644
--- a/third_party/leveldatabase/BUILD.gn
+++ b/third_party/leveldatabase/BUILD.gn
@@ -131,6 +131,8 @@ static_library("leveldatabase") {
]
if (is_win) {
+ # leveldb compiles with a limited set of warnings enabled, and is not
+ # likely to accept fixes for other warnings. See crbug.com/698013
cflags = [ "/wd4018" ] # Signed/unsigned mismatch in comparison.
if (is_official_build) {
@@ -205,8 +207,6 @@ if (!is_ios && !is_android) {
":leveldb_testutil",
]
- # TODO(crbug.com/698013): Fix leveldb to remove the need for suppressing
- # warnings.
if (is_win) {
# util\cache_test.cc(167): warning C4018: '<': signed/unsigned mismatch
# util\cache_test.cc(171): warning C4018: '<': signed/unsigned mismatch
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698