Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Side by Side Diff: third_party/leveldatabase/BUILD.gn

Issue 2788663003: Document the fact that leveldb sign warnings aren't getting fixed. (Closed)
Patch Set: Typo fix. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//testing/test.gni") 5 import("//testing/test.gni")
6 6
7 defines = [ "LEVELDB_PLATFORM_CHROMIUM=1" ] 7 defines = [ "LEVELDB_PLATFORM_CHROMIUM=1" ]
8 8
9 config("leveldatabase_config") { 9 config("leveldatabase_config") {
10 include_dirs = [ 10 include_dirs = [
(...skipping 113 matching lines...) Expand 10 before | Expand all | Expand 10 after
124 124
125 deps = [ 125 deps = [
126 ":leveldatabase_opts.sse42", 126 ":leveldatabase_opts.sse42",
127 "//base", 127 "//base",
128 "//base/third_party/dynamic_annotations", 128 "//base/third_party/dynamic_annotations",
129 "//third_party/re2", 129 "//third_party/re2",
130 "//third_party/snappy", 130 "//third_party/snappy",
131 ] 131 ]
132 132
133 if (is_win) { 133 if (is_win) {
134 # leveldb compiles with a limited set of warnings enabled, and is not
135 # likely to accept fixes for other warnings. See crbug.com/698013
134 cflags = [ "/wd4018" ] # Signed/unsigned mismatch in comparison. 136 cflags = [ "/wd4018" ] # Signed/unsigned mismatch in comparison.
135 137
136 if (is_official_build) { 138 if (is_official_build) {
137 # Function recursive on all control paths, crbug.com/620018 139 # Function recursive on all control paths, crbug.com/620018
138 cflags += [ "/wd4717" ] 140 cflags += [ "/wd4717" ]
139 } 141 }
140 } 142 }
141 } 143 }
142 144
143 if (!is_ios && !is_android) { 145 if (!is_ios && !is_android) {
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
198 test("leveldb_cache_test") { 200 test("leveldb_cache_test") {
199 sources = [ 201 sources = [
200 "src/util/cache_test.cc", 202 "src/util/cache_test.cc",
201 ] 203 ]
202 configs -= [ "//build/config/compiler:chromium_code" ] 204 configs -= [ "//build/config/compiler:chromium_code" ]
203 configs += [ "//build/config/compiler:no_chromium_code" ] 205 configs += [ "//build/config/compiler:no_chromium_code" ]
204 deps = [ 206 deps = [
205 ":leveldb_testutil", 207 ":leveldb_testutil",
206 ] 208 ]
207 209
208 # TODO(crbug.com/698013): Fix leveldb to remove the need for suppressing
209 # warnings.
210 if (is_win) { 210 if (is_win) {
211 # util\cache_test.cc(167): warning C4018: '<': signed/unsigned mismatch 211 # util\cache_test.cc(167): warning C4018: '<': signed/unsigned mismatch
212 # util\cache_test.cc(171): warning C4018: '<': signed/unsigned mismatch 212 # util\cache_test.cc(171): warning C4018: '<': signed/unsigned mismatch
213 cflags = [ "/wd4018" ] # Signed/unsigned mismatch in comparison. 213 cflags = [ "/wd4018" ] # Signed/unsigned mismatch in comparison.
214 } 214 }
215 } 215 }
216 216
217 test("leveldb_corruption_test") { 217 test("leveldb_corruption_test") {
218 sources = [ 218 sources = [
219 "src/db/corruption_test.cc", 219 "src/db/corruption_test.cc",
(...skipping 171 matching lines...) Expand 10 before | Expand all | Expand 10 after
391 ":leveldb_filename_test", 391 ":leveldb_filename_test",
392 ":leveldb_filter_block_test", 392 ":leveldb_filter_block_test",
393 ":leveldb_log_test", 393 ":leveldb_log_test",
394 ":leveldb_skiplist_test", 394 ":leveldb_skiplist_test",
395 ":leveldb_table_test", 395 ":leveldb_table_test",
396 ":leveldb_version_edit_test", 396 ":leveldb_version_edit_test",
397 ":leveldb_write_batch_test", 397 ":leveldb_write_batch_test",
398 ] 398 ]
399 } 399 }
400 } 400 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698