Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 2788583006: Delete content::MockURLRequestDelegate. (Closed)

Created:
3 years, 8 months ago by pwnall
Modified:
3 years, 8 months ago
Reviewers:
mattm, piman
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, cbentzel+watch_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, net-reviews_chromium.org, darin-cc_chromium.org, jkarlin+watch_chromium.org, horo+watch_chromium.org, kinuko+watch, shimazu+serviceworker_chromium.org, kinuko+fileapi, blink-worker-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete content::MockURLRequestDelegate. net::TestDelegate provides the functionality needed by the users of content::MockURLRequestDelegate, and is maintained by net/. Therefore, this CL moves all the clients to net::TestDelegate. BUG=653751 Review-Url: https://codereview.chromium.org/2788583006 Cr-Commit-Position: refs/heads/master@{#461996} Committed: https://chromium.googlesource.com/chromium/src/+/ca04d1cb992560ad509e4497252371327c0cde83

Patch Set 1 #

Total comments: 3

Patch Set 2 : Switch clients to net::TestDelegate instead of moving MockURLRequestDelegate. #

Total comments: 2

Patch Set 3 : Addressed feedback. #

Total comments: 2

Patch Set 4 : Addressed nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -169 lines) Patch
M content/browser/blob_storage/blob_url_request_job_unittest.cc View 1 2 3 11 chunks +12 lines, -12 lines 0 comments Download
M content/browser/cache_storage/cache_storage_cache_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
D content/browser/fileapi/mock_url_request_delegate.h View 1 chunk +0 lines, -43 lines 0 comments Download
D content/browser/fileapi/mock_url_request_delegate.cc View 1 chunk +0 lines, -86 lines 0 comments Download
M content/browser/service_worker/foreign_fetch_request_handler_unittest.cc View 1 3 chunks +2 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_context_request_handler_unittest.cc View 1 3 chunks +2 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_controllee_request_handler_unittest.cc View 1 3 chunks +2 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_read_from_cache_job_unittest.cc View 1 3 chunks +2 lines, -3 lines 0 comments Download
M content/browser/service_worker/service_worker_request_handler_unittest.cc View 1 3 chunks +2 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_url_request_job_unittest.cc View 1 12 chunks +12 lines, -12 lines 0 comments Download
M content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc View 1 2 chunks +1 line, -2 lines 0 comments Download
M content/test/BUILD.gn View 1 2 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 31 (21 generated)
pwnall
mattm@chromium.org: Please review the move of MockUrlRequestDelegate to net/ piman@chromium.org: Please review the #include changes ...
3 years, 8 months ago (2017-03-31 19:58:04 UTC) #4
mattm
https://codereview.chromium.org/2788583006/diff/1/content/browser/cache_storage/cache_storage_cache_unittest.cc File content/browser/cache_storage/cache_storage_cache_unittest.cc (right): https://codereview.chromium.org/2788583006/diff/1/content/browser/cache_storage/cache_storage_cache_unittest.cc#newcode35 content/browser/cache_storage/cache_storage_cache_unittest.cc:35: #include "net/test/url_request/mock_url_request_delegate.h" Is MockURLRequestDelegate used in this file? https://codereview.chromium.org/2788583006/diff/1/net/test/url_request/mock_url_request_delegate.h ...
3 years, 8 months ago (2017-03-31 21:52:02 UTC) #7
piman
rs LGTM
3 years, 8 months ago (2017-04-03 23:53:25 UTC) #8
pwnall
mattm: Thank you for the great suggestion! PTAL? piman: Thank you for the quick turnaround ...
3 years, 8 months ago (2017-04-04 02:28:21 UTC) #12
mattm
https://codereview.chromium.org/2788583006/diff/20001/content/browser/blob_storage/blob_url_request_job_unittest.cc File content/browser/blob_storage/blob_url_request_job_unittest.cc (right): https://codereview.chromium.org/2788583006/diff/20001/content/browser/blob_storage/blob_url_request_job_unittest.cc#newcode495 content/browser/blob_storage/blob_url_request_job_unittest.cc:495: EXPECT_FALSE(url_request_delegate_.metadata()); Instead of adding to TestDelegate, does it work ...
3 years, 8 months ago (2017-04-04 21:02:28 UTC) #15
pwnall
mattm: Thank you very much for your help and patience! This CL doesn't touch net/ ...
3 years, 8 months ago (2017-04-04 21:41:16 UTC) #19
mattm
lgtm w/nit https://codereview.chromium.org/2788583006/diff/40001/content/browser/blob_storage/blob_url_request_job_unittest.cc File content/browser/blob_storage/blob_url_request_job_unittest.cc (right): https://codereview.chromium.org/2788583006/diff/40001/content/browser/blob_storage/blob_url_request_job_unittest.cc#newcode583 content/browser/blob_storage/blob_url_request_job_unittest.cc:583: EXPECT_TRUE(request_->response_info().metadata); While you're here, could change this ...
3 years, 8 months ago (2017-04-04 22:06:34 UTC) #20
pwnall
mattm: Thank you very much for the review! https://codereview.chromium.org/2788583006/diff/40001/content/browser/blob_storage/blob_url_request_job_unittest.cc File content/browser/blob_storage/blob_url_request_job_unittest.cc (right): https://codereview.chromium.org/2788583006/diff/40001/content/browser/blob_storage/blob_url_request_job_unittest.cc#newcode583 content/browser/blob_storage/blob_url_request_job_unittest.cc:583: EXPECT_TRUE(request_->response_info().metadata); ...
3 years, 8 months ago (2017-04-04 22:29:20 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2788583006/60001
3 years, 8 months ago (2017-04-05 07:09:22 UTC) #28
commit-bot: I haz the power
3 years, 8 months ago (2017-04-05 07:14:39 UTC) #31
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/ca04d1cb992560ad509e44972523...

Powered by Google App Engine
This is Rietveld 408576698