Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Unified Diff: content/browser/service_worker/service_worker_read_from_cache_job_unittest.cc

Issue 2788583006: Delete content::MockURLRequestDelegate. (Closed)
Patch Set: Addressed nit. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_read_from_cache_job_unittest.cc
diff --git a/content/browser/service_worker/service_worker_read_from_cache_job_unittest.cc b/content/browser/service_worker/service_worker_read_from_cache_job_unittest.cc
index 81c64a953b8d47708503f40b1ba6e086786924bf..d21567a6b0d1463bfa6cc553cc771774655a7242 100644
--- a/content/browser/service_worker/service_worker_read_from_cache_job_unittest.cc
+++ b/content/browser/service_worker/service_worker_read_from_cache_job_unittest.cc
@@ -11,7 +11,6 @@
#include "base/macros.h"
#include "base/memory/ptr_util.h"
#include "base/run_loop.h"
-#include "content/browser/fileapi/mock_url_request_delegate.h"
#include "content/browser/service_worker/embedded_worker_test_helper.h"
#include "content/browser/service_worker/service_worker_context_core.h"
#include "content/browser/service_worker/service_worker_registration.h"
@@ -162,7 +161,7 @@ class ServiceWorkerReadFromCacheJobTest : public testing::Test {
void StartAndWaitForRequest(net::URLRequest* request) {
request->Start();
- // MockURLRequestDelegate quits the loop when the request is completed.
+ // net::TestDelegate quits the loop when the request is completed.
base::RunLoop().RunUntilIdle();
}
@@ -187,7 +186,7 @@ class ServiceWorkerReadFromCacheJobTest : public testing::Test {
net::URLRequestJobFactoryImpl test_job_factory_;
std::unique_ptr<net::TestURLRequestContext> url_request_context_;
- MockURLRequestDelegate delegate_;
+ net::TestDelegate delegate_;
};
TEST_F(ServiceWorkerReadFromCacheJobTest, ReadMainScript) {

Powered by Google App Engine
This is Rietveld 408576698