content/browser/service_worker/service_worker_request_handler_unittest.cc - Issue 2788583006: Delete content::MockURLRequestDelegate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_request_handler_unittest.cc

Issue 2788583006: Delete content::MockURLRequestDelegate. (Closed)

Patch Set: Addressed nit. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_read_from_cache_job_unittest.cc ('k') | content/browser/service_worker/service_worker_url_request_job_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_request_handler_unittest.cc

diff --git a/content/browser/service_worker/service_worker_request_handler_unittest.cc b/content/browser/service_worker/service_worker_request_handler_unittest.cc

index 93f795b35337d0d235f65cd27b8e4f181678428a..d8f8d190c8f27d5e223276cad71e6e4bb02c15bf 100644

--- a/content/browser/service_worker/service_worker_request_handler_unittest.cc

+++ b/content/browser/service_worker/service_worker_request_handler_unittest.cc

@@ -7,7 +7,6 @@

#include <utility>

#include "base/run_loop.h"

-#include "content/browser/fileapi/mock_url_request_delegate.h"

#include "content/browser/service_worker/embedded_worker_test_helper.h"

#include "content/browser/service_worker/service_worker_context_core.h"

#include "content/browser/service_worker/service_worker_context_wrapper.h"

@@ -22,6 +21,7 @@

#include "net/url_request/redirect_info.h"

#include "net/url_request/url_request_context.h"

#include "net/url_request/url_request_job.h"

+#include "net/url_request/url_request_test_util.h"

#include "storage/browser/blob/blob_storage_context.h"

#include "testing/gtest/include/gtest/gtest.h"

@@ -107,7 +107,7 @@ class ServiceWorkerRequestHandlerTest : public testing::Test {

std::unique_ptr<EmbeddedWorkerTestHelper> helper_;

base::WeakPtr<ServiceWorkerProviderHost> provider_host_;

net::URLRequestContext url_request_context_;

- MockURLRequestDelegate url_request_delegate_;

+ net::TestDelegate url_request_delegate_;

storage::BlobStorageContext blob_storage_context_;

};