Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 2788533002: [ES6 modules] Make Modulator regular GCollected / not mixin (Closed)

Created:
3 years, 8 months ago by kouhei (in TOK)
Modified:
3 years, 8 months ago
Reviewers:
hiroshige, yhirano
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ES6 modules] Make Modulator regular GCollected / not mixin Before this CL, Modulator was a GCMixin, but there was no reason that it needed to be a mixin. This CL changes it to a regular GarbageCollectedFinalized obj. This CL prepares Modulator/ModuleMap/ModuleMap::Entry/ModuleScript to be converted into TraceWrapperBase. BUG=594639 Review-Url: https://codereview.chromium.org/2788533002 Cr-Commit-Position: refs/heads/master@{#460696} Committed: https://chromium.googlesource.com/chromium/src/+/679a8ee1b416d892b465fc505a8e695f6788cf13

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M third_party/WebKit/Source/core/dom/Modulator.h View 1 chunk +4 lines, -1 line 1 comment Download
M third_party/WebKit/Source/core/dom/Modulator.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/testing/DummyModulator.h View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/testing/DummyModulator.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
kouhei (in TOK)
3 years, 8 months ago (2017-03-30 04:22:54 UTC) #2
hiroshige
lgtm
3 years, 8 months ago (2017-03-30 05:08:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2788533002/1
3 years, 8 months ago (2017-03-30 05:21:26 UTC) #5
yhirano
https://codereview.chromium.org/2788533002/diff/1/third_party/WebKit/Source/core/dom/Modulator.h File third_party/WebKit/Source/core/dom/Modulator.h (right): https://codereview.chromium.org/2788533002/diff/1/third_party/WebKit/Source/core/dom/Modulator.h#newcode42 third_party/WebKit/Source/core/dom/Modulator.h:42: class CORE_EXPORT Modulator : public GarbageCollectedFinalized<Modulator> { Is "Finalized" ...
3 years, 8 months ago (2017-03-30 07:22:42 UTC) #6
kouhei (in TOK)
On 2017/03/30 07:22:42, yhirano wrote: > https://codereview.chromium.org/2788533002/diff/1/third_party/WebKit/Source/core/dom/Modulator.h > File third_party/WebKit/Source/core/dom/Modulator.h (right): > > https://codereview.chromium.org/2788533002/diff/1/third_party/WebKit/Source/core/dom/Modulator.h#newcode42 > ...
3 years, 8 months ago (2017-03-30 07:26:45 UTC) #7
yhirano
lgtm
3 years, 8 months ago (2017-03-30 07:27:38 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-03-30 08:34:52 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/679a8ee1b416d892b465fc505a8e...

Powered by Google App Engine
This is Rietveld 408576698