third_party/WebKit/Source/core/dom/Modulator.cpp - Issue 2788533002: [ES6 modules] Make Modulator regular GCollected / not mixin

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Modulator.cpp

Issue 2788533002: [ES6 modules] Make Modulator regular GCollected / not mixin (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/Modulator.cpp

diff --git a/third_party/WebKit/Source/core/dom/Modulator.cpp b/third_party/WebKit/Source/core/dom/Modulator.cpp

index 58dc787c332ea5a7bdb1d2c39b56bb9e0439f74f..c5a8aed9e1f46cc004a82536dfcb740228c8ef02 100644

--- a/third_party/WebKit/Source/core/dom/Modulator.cpp

+++ b/third_party/WebKit/Source/core/dom/Modulator.cpp

@@ -16,6 +16,8 @@ Modulator* Modulator::from(LocalFrame* frame) {

return scriptState->perContextData()->modulator();

}

+Modulator::~Modulator() {}

KURL Modulator::resolveModuleSpecifier(const String& moduleRequest,

const KURL& baseURL) {

// Step 1. Apply the URL parser to specifier. If the result is not failure,