Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Unified Diff: third_party/WebKit/Source/core/dom/Modulator.h

Issue 2788533002: [ES6 modules] Make Modulator regular GCollected / not mixin (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/dom/Modulator.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/dom/Modulator.h
diff --git a/third_party/WebKit/Source/core/dom/Modulator.h b/third_party/WebKit/Source/core/dom/Modulator.h
index 353c99511ea9f0a7798fa42629f7b07dd88e6e44..22517c73622907a69f17327d9a7ead0d4a4545aa 100644
--- a/third_party/WebKit/Source/core/dom/Modulator.h
+++ b/third_party/WebKit/Source/core/dom/Modulator.h
@@ -39,9 +39,12 @@ enum class ModuleGraphLevel { TopLevelModuleFetch, DependentModuleFetch };
// https://html.spec.whatwg.org/#environment-settings-object
//
// A Modulator also serves as an entry point for various module spec algorithms.
-class CORE_EXPORT Modulator : public GarbageCollectedMixin {
+class CORE_EXPORT Modulator : public GarbageCollectedFinalized<Modulator> {
yhirano 2017/03/30 07:22:42 Is "Finalized" needed?
public:
static Modulator* from(LocalFrame*);
+ virtual ~Modulator();
+
+ DEFINE_INLINE_VIRTUAL_TRACE() {}
virtual ScriptModuleResolver* scriptModuleResolver() = 0;
virtual WebTaskRunner* taskRunner() = 0;
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/dom/Modulator.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698