Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 2788143003: Use SameDocument term in subresource_filter tests. (Closed)

Created:
3 years, 8 months ago by Eugene But (OOO till 7-30)
Modified:
3 years, 8 months ago
Reviewers:
melandory
CC:
chromium-reviews, darin-cc_chromium.org, jam, subresource-filter-reviews_chromium.org, mlamouri+watch-content_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use SameDocument term in subresource_filter tests. Old name was presumably used to match was_within_same_page IPC, but SameDocument name better reflects the the type of the navigation (navigation did not change the document object). This change will make naming more consistent with the rest of Chromium code. BUG=695189 Review-Url: https://codereview.chromium.org/2788143003 Cr-Commit-Position: refs/heads/master@{#461465} Committed: https://chromium.googlesource.com/chromium/src/+/5ffab89a82a2dbf5e7b974fb41f7a9767e846c03

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M components/subresource_filter/content/browser/content_subresource_filter_throttle_manager_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/subresource_filter/content/renderer/subresource_filter_agent_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Eugene But (OOO till 7-30)
PTAL
3 years, 8 months ago (2017-04-01 02:26:32 UTC) #6
melandory
On 2017/04/01 02:26:32, Eugene But wrote: > PTAL lgtm
3 years, 8 months ago (2017-04-03 11:47:09 UTC) #7
Eugene But (OOO till 7-30)
Thanks!
3 years, 8 months ago (2017-04-03 16:54:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2788143003/1
3 years, 8 months ago (2017-04-03 16:55:24 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-03 17:39:32 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5ffab89a82a2dbf5e7b974fb41f7...

Powered by Google App Engine
This is Rietveld 408576698