Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(698)

Unified Diff: components/subresource_filter/content/renderer/subresource_filter_agent_unittest.cc

Issue 2788143003: Use SameDocument term in subresource_filter tests. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/subresource_filter/content/browser/content_subresource_filter_throttle_manager_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/subresource_filter/content/renderer/subresource_filter_agent_unittest.cc
diff --git a/components/subresource_filter/content/renderer/subresource_filter_agent_unittest.cc b/components/subresource_filter/content/renderer/subresource_filter_agent_unittest.cc
index a48257557d0bfcff68be9fb5f0c46e5b68fa9479..71211bfc1d81cf3cb4443372d6a69480958a2fbe 100644
--- a/components/subresource_filter/content/renderer/subresource_filter_agent_unittest.cc
+++ b/components/subresource_filter/content/renderer/subresource_filter_agent_unittest.cc
@@ -127,10 +127,10 @@ class SubresourceFilterAgentTest : public ::testing::Test {
true /* is_new_navigation */, false /* is_same_document_navigation */);
}
- void PerformSamePageNavigationWithoutSettingActivationLevel() {
+ void PerformSameDocumentNavigationWithoutSettingActivationLevel() {
agent_as_rfo()->DidStartProvisionalLoad(nullptr);
agent_as_rfo()->DidCommitProvisionalLoad(
- true /* is_new_navigation */, true /* is_same_page_navigation */);
+ true /* is_new_navigation */, true /* is_same_document_navigation */);
// No DidFinishLoad is called in this case.
}
@@ -293,7 +293,7 @@ TEST_F(SubresourceFilterAgentTest, Enabled_FilteringIsInEffectForOneLoad) {
// In-page navigation should not count as a new load.
ExpectNoSubresourceFilterGetsInjected();
ExpectNoSignalAboutFirstSubresourceDisallowed();
- PerformSamePageNavigationWithoutSettingActivationLevel();
+ PerformSameDocumentNavigationWithoutSettingActivationLevel();
ExpectLoadPolicy(kTestFirstURL,
blink::WebDocumentSubresourceFilter::kDisallow);
ExpectLoadPolicy(kTestSecondURL, blink::WebDocumentSubresourceFilter::kAllow);
« no previous file with comments | « components/subresource_filter/content/browser/content_subresource_filter_throttle_manager_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698