Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(785)

Unified Diff: components/subresource_filter/content/browser/content_subresource_filter_throttle_manager_unittest.cc

Issue 2788143003: Use SameDocument term in subresource_filter tests. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/subresource_filter/content/renderer/subresource_filter_agent_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/subresource_filter/content/browser/content_subresource_filter_throttle_manager_unittest.cc
diff --git a/components/subresource_filter/content/browser/content_subresource_filter_throttle_manager_unittest.cc b/components/subresource_filter/content/browser/content_subresource_filter_throttle_manager_unittest.cc
index 100da0e04b57f8dbbf08d4e33354a89630e532c4..5d02b2f69d38d8f97fac847b3f1030ae1e4c1e0c 100644
--- a/components/subresource_filter/content/browser/content_subresource_filter_throttle_manager_unittest.cc
+++ b/components/subresource_filter/content/browser/content_subresource_filter_throttle_manager_unittest.cc
@@ -195,7 +195,7 @@ class ContentSubresourceFilterThrottleManagerTest
return nullptr;
}
- void SimulateSamePageCommit() {
+ void SimulateSameDocumentCommit() {
navigation_simulator_->CommitSameDocument();
navigation_simulator_.reset();
}
@@ -413,7 +413,7 @@ TEST_P(ContentSubresourceFilterThrottleManagerTest,
// Commit another navigation that triggers page level activation.
GURL url2 = GURL(base::StringPrintf("%s#ref", kTestURLWithActivation));
CreateTestNavigation(url2, main_rfh());
- SimulateSamePageCommit();
+ SimulateSameDocumentCommit();
CreateSubframeWithTestNavigation(
GURL("https://www.example.com/2/disallowed.html"), main_rfh());
« no previous file with comments | « no previous file | components/subresource_filter/content/renderer/subresource_filter_agent_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698