[ios] Clean up uses of private web API.

[ios] Clean up uses of private web API.

Convert usages of CRWWebController -setWebUsageEnabled:, -stopLoading,
-loadWithParams:, -triggerPendingLoad and -setShouldSuppressDialogs: to
instead use the corresponding API of WebState or NavigationManager (or
to use indirect call via WebState::GetView()).

Remove use of CRWWebController -webStateImpl in TabTest instead using
the pointer to the WebStateImpl owned by TabTest.

BUG=None

Review-Url: https://codereview.chromium.org/2787593002
Cr-Commit-Position: refs/heads/master@{#462049}
Committed: https://chromium.googlesource.com/chromium/src/+/7d699dd15bd2fc988a0db0f79b1a705adcce6226

[sdefresne, 2017-03-29 18:27:52]

sdefresne@chromium.org changed reviewers:
+ justincohen@chromium.org

[sdefresne, 2017-03-29 18:27:53]

Please take a look.

[justincohen, 2017-03-30 03:23:17]

lgtm with q

https://codereview.chromium.org/2787593002/diff/1/ios/chrome/browser/tabs/tab...
File ios/chrome/browser/tabs/tab_model.mm (right):

https://codereview.chromium.org/2787593002/diff/1/ios/chrome/browser/tabs/tab...
ios/chrome/browser/tabs/tab_model.mm:571:
webState->SetWebUsageEnabled(webUsageEnabled_ ? true : false);
Is there any reason to wrap this inside webStateList, e..g
webStateList->SetWebUsageEnabled() to set all webstate's at once?

[sdefresne, 2017-03-30 09:37:40]

https://codereview.chromium.org/2787593002/diff/1/ios/chrome/browser/tabs/tab...
File ios/chrome/browser/tabs/tab_model.mm (right):

https://codereview.chromium.org/2787593002/diff/1/ios/chrome/browser/tabs/tab...
ios/chrome/browser/tabs/tab_model.mm:571:
webState->SetWebUsageEnabled(webUsageEnabled_ ? true : false);
On 2017/03/30 03:23:17, justincohen wrote:
> Is there any reason to wrap this inside webStateList, e..g
> webStateList->SetWebUsageEnabled() to set all webstate's at once?

I don't thinks this should be the responsibility of WebStateList. Otherwise you
end up with a kitchensink class. This would most likely be the responsibility of
Browser or some higher class. That class can iterate over all WebStates.

BTW, this is almost never called (this is only ever called during tests).

[sdefresne, 2017-03-30 09:47:10]

+eugenebut (cc): FYI

[Eugene But (OOO till 7-30), 2017-03-30 14:50:14]

eugenebut@chromium.org changed reviewers:
+ eugenebut@chromium.org

[Eugene But (OOO till 7-30), 2017-03-30 14:50:15]

Great, thanks for CCing!

https://codereview.chromium.org/2787593002/diff/1/ios/chrome/browser/tabs/tab...
File ios/chrome/browser/tabs/tab_model.mm (right):

https://codereview.chromium.org/2787593002/diff/1/ios/chrome/browser/tabs/tab...
ios/chrome/browser/tabs/tab_model.mm:487: webStatePtr->GetView();
Could you please add TODO(crbug.com/705819): Remove this call.

https://codereview.chromium.org/2787593002/diff/1/ios/chrome/browser/ui/prelo...
File ios/chrome/browser/ui/preload_controller.mm (right):

https://codereview.chromium.org/2787593002/diff/1/ios/chrome/browser/ui/prelo...
ios/chrome/browser/ui/preload_controller.mm:411: // Trigger the page to start
loading.
Could you please add the same TODO here

[sdefresne, 2017-04-05 11:56:05]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 11:56:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2017-04-05 12:55:03]

https://codereview.chromium.org/2787593002/diff/1/ios/chrome/browser/tabs/tab...
File ios/chrome/browser/tabs/tab_model.mm (right):

https://codereview.chromium.org/2787593002/diff/1/ios/chrome/browser/tabs/tab...
ios/chrome/browser/tabs/tab_model.mm:487: webStatePtr->GetView();
On 2017/03/30 14:50:15, Eugene But wrote:
> Could you please add TODO(crbug.com/705819): Remove this call.

Done.

https://codereview.chromium.org/2787593002/diff/1/ios/chrome/browser/ui/prelo...
File ios/chrome/browser/ui/preload_controller.mm (right):

https://codereview.chromium.org/2787593002/diff/1/ios/chrome/browser/ui/prelo...
ios/chrome/browser/ui/preload_controller.mm:411: // Trigger the page to start
loading.
On 2017/03/30 14:50:15, Eugene But wrote:
> Could you please add the same TODO here

Done.

[sdefresne, 2017-04-05 12:55:14]

The CQ bit was checked by sdefresne@chromium.org

[sdefresne, 2017-04-05 12:55:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
justincohen@chromium.org
Link to the patchset: https://codereview.chromium.org/2787593002/#ps40001
(title: "Address comments (add TODO).")

[commit-bot: I haz the power, 2017-04-05 12:55:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 13:05:27]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491396914638160,
"parent_rev": "253fe7d912b4e16fd56c6ce0a68906d0f1a376e2", "commit_rev":
"7d699dd15bd2fc988a0db0f79b1a705adcce6226"}

[commit-bot: I haz the power, 2017-04-05 13:06:16]

Description was changed from

==========
[ios] Clean up uses of private web API.

Convert usages of CRWWebController -setWebUsageEnabled:, -stopLoading,
-loadWithParams:, -triggerPendingLoad and -setShouldSuppressDialogs: to
instead use the corresponding API of WebState or NavigationManager (or
to use indirect call via WebState::GetView()).

Remove use of CRWWebController -webStateImpl in TabTest instead using
the pointer to the WebStateImpl owned by TabTest.

BUG=None
==========

to

==========
[ios] Clean up uses of private web API.

Convert usages of CRWWebController -setWebUsageEnabled:, -stopLoading,
-loadWithParams:, -triggerPendingLoad and -setShouldSuppressDialogs: to
instead use the corresponding API of WebState or NavigationManager (or
to use indirect call via WebState::GetView()).

Remove use of CRWWebController -webStateImpl in TabTest instead using
the pointer to the WebStateImpl owned by TabTest.

BUG=None

Review-Url: https://codereview.chromium.org/2787593002
Cr-Commit-Position: refs/heads/master@{#462049}
Committed:
https://chromium.googlesource.com/chromium/src/+/7d699dd15bd2fc988a0db0f79b1a...
==========

[commit-bot: I haz the power, 2017-04-05 13:06:17]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/7d699dd15bd2fc988a0db0f79b1a...