ios/chrome/browser/tabs/tab_model_unittest.mm - Issue 2787593002: [ios] Clean up uses of private web API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/tabs/tab_model_unittest.mm

Issue 2787593002: [ios] Clean up uses of private web API. (Closed)

Patch Set: Address comments (add TODO). Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/browser/tabs/tab_model_unittest.mm

diff --git a/ios/chrome/browser/tabs/tab_model_unittest.mm b/ios/chrome/browser/tabs/tab_model_unittest.mm

index adfc7755952ffff619d4639e7edb7da46867a6a8..8b31c71ac3153c622ecd37e0c059f72f35ff5493 100644

--- a/ios/chrome/browser/tabs/tab_model_unittest.mm

+++ b/ios/chrome/browser/tabs/tab_model_unittest.mm

@@ -867,7 +867,7 @@ TEST_F(TabModelTest, AddWithOrderControllerAndGrouping) {

web::NavigationManager::WebLoadParams parent_params(

GURL("http://www.espn.com"));

parent_params.transition_type = ui::PAGE_TRANSITION_TYPED;

- [[parent webController] loadWithParams:parent_params];

+ [parent navigationManager]->LoadURLWithParams(parent_params);

ASSERT_TRUE([parent navigationManagerImpl]);

[[parent navigationManagerImpl]->GetSessionController() commitPendingItem];

EXPECT_EQ([tab_model_ indexOfTab:parent], 0U);

« no previous file with comments | « ios/chrome/browser/tabs/tab_model.mm ('k') | ios/chrome/browser/tabs/tab_unittest.mm » ('j') | no next file with comments »