[ios] Extend BrowserList API.

[ios] Extend BrowserList API.

Add a method BrowserList::GetIndexOfBrowser() to find the index of
a Browser instance to simplify closing Browsers (since Browser are
closed by index, not pointer).

Rename GetBrowserCount() method to count() and inline it as it is
a simple function (just a wrapper around std::vector::size()) and
not inlining it could make the iteration over the BrowserList slow.

BUG=None

Review-Url: https://codereview.chromium.org/2798863004
Cr-Commit-Position: refs/heads/master@{#462452}
Committed: https://chromium.googlesource.com/chromium/src/+/3a375fc9d871fe97a5a2bc23e5471d95619f1c49

[sdefresne, 2017-04-05 12:50:32]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[sdefresne, 2017-04-05 12:50:43]

sdefresne@chromium.org changed reviewers:
+ marq@chromium.org

[sdefresne, 2017-04-05 12:50:44]

Please take a look.

[commit-bot: I haz the power, 2017-04-05 12:50:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 13:00:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 13:00:27]

Dry run: This issue passed the CQ dry run.

[marq (ping after 24h), 2017-04-05 13:43:24]

LGTM

What's the motivation for these additions? Can you add that to the CL
description?

https://codereview.chromium.org/2798863004/diff/1/ios/shared/chrome/browser/u...
File ios/shared/chrome/browser/ui/browser_list/browser_list.h (right):

https://codereview.chromium.org/2798863004/diff/1/ios/shared/chrome/browser/u...
ios/shared/chrome/browser/ui/browser_list/browser_list.h:28: int count() const {
return static_cast<int>(browsers_.size()); }
Why move the implementation to the header?

[sdefresne, 2017-04-06 11:31:21]

Description was changed from

==========
[ios] Extend BrowserList API.

Add a BrowserList::GetIndexOfBrowser(). Rename GetBrowserCount() and
GetBrowserAtIndex() methods to count() and GetBrowserAt() to match
WebStateList API.

BUG=None
==========

to

==========
[ios] Extend BrowserList API.

Add a method BrowserList::GetIndexOfBrowser() to find the index of
a Browser instance to simplify closing Browsers (since Browser are
closed by index, not pointer).

Rename GetBrowserCount() method to count() and inline it as it is
a simple function (just a wrapper around std::vector::size()) and
not inlining it could make the iteration over the BrowserList slow.

BUG=None
==========

[sdefresne, 2017-04-06 11:32:47]

Updated the description to explain why the new method was added. Revert the name
change of GetBrowserAtIndex().

https://codereview.chromium.org/2798863004/diff/1/ios/shared/chrome/browser/u...
File ios/shared/chrome/browser/ui/browser_list/browser_list.h (right):

https://codereview.chromium.org/2798863004/diff/1/ios/shared/chrome/browser/u...
ios/shared/chrome/browser/ui/browser_list/browser_list.h:28: int count() const {
return static_cast<int>(browsers_.size()); }
On 2017/04/05 13:43:24, marq wrote:
> Why move the implementation to the header?

It is a trivial accessor and worth inlining (this is allowed by the style guide:
https://google.github.io/styleguide/cppguide.html#Inline_Functions).

[sdefresne, 2017-04-06 13:21:09]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-06 13:21:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 13:30:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 13:30:25]

Dry run: This issue passed the CQ dry run.

[sdefresne, 2017-04-06 13:32:46]

The CQ bit was checked by sdefresne@chromium.org

[sdefresne, 2017-04-06 13:32:46]

The patchset sent to the CQ was uploaded after l-g-t-m from marq@chromium.org
Link to the patchset: https://codereview.chromium.org/2798863004/#ps20001
(title: "Revert name change of GetBrowserAtIndex().")

[commit-bot: I haz the power, 2017-04-06 13:32:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 13:38:00]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491485566398800,
"parent_rev": "d4b92153f875c211e8c6f01603ed510962200747", "commit_rev":
"3a375fc9d871fe97a5a2bc23e5471d95619f1c49"}

[commit-bot: I haz the power, 2017-04-06 13:38:52]

Description was changed from

==========
[ios] Extend BrowserList API.

Add a method BrowserList::GetIndexOfBrowser() to find the index of
a Browser instance to simplify closing Browsers (since Browser are
closed by index, not pointer).

Rename GetBrowserCount() method to count() and inline it as it is
a simple function (just a wrapper around std::vector::size()) and
not inlining it could make the iteration over the BrowserList slow.

BUG=None
==========

to

==========
[ios] Extend BrowserList API.

Add a method BrowserList::GetIndexOfBrowser() to find the index of
a Browser instance to simplify closing Browsers (since Browser are
closed by index, not pointer).

Rename GetBrowserCount() method to count() and inline it as it is
a simple function (just a wrapper around std::vector::size()) and
not inlining it could make the iteration over the BrowserList slow.

BUG=None

Review-Url: https://codereview.chromium.org/2798863004
Cr-Commit-Position: refs/heads/master@{#462452}
Committed:
https://chromium.googlesource.com/chromium/src/+/3a375fc9d871fe97a5a2bc23e547...
==========

[commit-bot: I haz the power, 2017-04-06 13:38:53]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3a375fc9d871fe97a5a2bc23e547...