Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2786993002: Convert top-level inference errors to hints (Closed)

Created:
3 years, 8 months ago by Brian Wilkerson
Modified:
3 years, 8 months ago
Reviewers:
Leaf
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Convert top-level inference errors to hints Committed: https://github.com/dart-lang/sdk/commit/ad54733d46759c422f055119b689881a9c4922b7

Patch Set 1 #

Patch Set 2 : Preserve the new hints #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -14 lines) Patch
M pkg/analyzer/lib/src/error/codes.dart View 1 chunk +12 lines, -7 lines 0 comments Download
M pkg/analyzer/lib/src/task/strong/checker.dart View 1 1 chunk +7 lines, -1 line 2 comments Download
M pkg/analyzer/test/generated/hint_code_test.dart View 1 4 chunks +20 lines, -6 lines 0 comments Download
M pkg/analyzer/test/src/task/strong/strong_test_helper.dart View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Brian Wilkerson
3 years, 8 months ago (2017-03-30 18:46:45 UTC) #2
Leaf
https://codereview.chromium.org/2786993002/diff/20001/pkg/analyzer/lib/src/task/strong/checker.dart File pkg/analyzer/lib/src/task/strong/checker.dart (right): https://codereview.chromium.org/2786993002/diff/20001/pkg/analyzer/lib/src/task/strong/checker.dart#newcode1055 pkg/analyzer/lib/src/task/strong/checker.dart:1055: _failure = true; I don't think we want to ...
3 years, 8 months ago (2017-03-30 19:39:59 UTC) #3
Brian Wilkerson
https://codereview.chromium.org/2786993002/diff/20001/pkg/analyzer/lib/src/task/strong/checker.dart File pkg/analyzer/lib/src/task/strong/checker.dart (right): https://codereview.chromium.org/2786993002/diff/20001/pkg/analyzer/lib/src/task/strong/checker.dart#newcode1055 pkg/analyzer/lib/src/task/strong/checker.dart:1055: _failure = true; Done
3 years, 8 months ago (2017-03-30 19:45:19 UTC) #4
Brian Wilkerson
3 years, 8 months ago (2017-03-30 19:46:00 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
ad54733d46759c422f055119b689881a9c4922b7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698