Convert top-level inference errors to hints

pkg/analyzer/lib/src/error/codes.dart

Index: pkg/analyzer/lib/src/error/codes.dart
diff --git a/pkg/analyzer/lib/src/error/codes.dart b/pkg/analyzer/lib/src/error/codes.dart
index f650d544bfa52843f9f9660b4acb2a133dddc2e2..df5e5eeb84e2bb3759548f36402c1836ad2c171f 100644
--- a/pkg/analyzer/lib/src/error/codes.dart
+++ b/pkg/analyzer/lib/src/error/codes.dart
@@ -4951,46 +4951,51 @@ class StrongModeCode extends ErrorCode {
       "Type parameter bound types must be instantiated.",
       "Try adding type arguments.");
 
+  /*
+   * TODO(brianwilkerson) Make the TOP_LEVEL_ error codes be errors rather than
+   * hints and then clean up the function _errorSeverity in
+   * test/src/task/strong/strong_test_helper.dart.
+   */
   static const StrongModeCode TOP_LEVEL_CYCLE = const StrongModeCode(
-      ErrorType.COMPILE_TIME_ERROR,
+      ErrorType.HINT,
       'TOP_LEVEL_CYCLE',
       "The type of '{0}' can't be inferred because it depends on itself through the cycle: {1}.",
       "Try adding an explicit type to one or more of the variables in the cycle in order to break the cycle.");
 
   static const StrongModeCode TOP_LEVEL_FUNCTION_LITERAL_BLOCK =
       const StrongModeCode(
-          ErrorType.COMPILE_TIME_ERROR,
+          ErrorType.HINT,
           'TOP_LEVEL_FUNCTION_LITERAL_BLOCK',
           "The type of the function literal can't be inferred because the literal has a block as its body.",
           "Try adding an explicit type to the variable.");
 
   static const StrongModeCode TOP_LEVEL_FUNCTION_LITERAL_PARAMETER =
       const StrongModeCode(
-          ErrorType.COMPILE_TIME_ERROR,
+          ErrorType.HINT,
           'TOP_LEVEL_FUNCTION_LITERAL_PARAMETER',
           "The type of '{0}' can't be inferred because the parameter '{1}' does not have an explicit type.",
           "Try adding an explicit type to the parameter '{1}', or add an explicit type for '{0}'.");
 
   static const StrongModeCode TOP_LEVEL_IDENTIFIER_NO_TYPE = const StrongModeCode(
-      ErrorType.COMPILE_TIME_ERROR,
+      ErrorType.HINT,
       'TOP_LEVEL_IDENTIFIER_NO_TYPE',
       "The type of '{0}' can't be inferred because the type of '{1}' couldn't be inferred.",
       "Try adding an explicit type to either the variable '{0}' or the variable '{1}'.");
 
   static const StrongModeCode TOP_LEVEL_INSTANCE_GETTER = const StrongModeCode(
-      ErrorType.COMPILE_TIME_ERROR,
+      ErrorType.HINT,
       'TOP_LEVEL_INSTANCE_GETTER',
       "The type of '{0}' can't be inferred because of the use of the instance getter '{1}'.",
       "Try removing the use of the instance getter {1}, or add an explicit type for '{0}'.");
 
   static const StrongModeCode TOP_LEVEL_TYPE_ARGUMENTS = const StrongModeCode(
-      ErrorType.COMPILE_TIME_ERROR,
+      ErrorType.HINT,
       'TOP_LEVEL_TYPE_ARGUMENTS',
       "The type of '{0}' can't be inferred because type arguments were not given for '{1}'.",
       "Try adding type arguments for '{1}', or add an explicit type for '{0}'.");
 
   static const StrongModeCode TOP_LEVEL_UNSUPPORTED = const StrongModeCode(
-      ErrorType.COMPILE_TIME_ERROR,
+      ErrorType.HINT,
       'TOP_LEVEL_UNSUPPORTED',
       "The type of '{0}' can't be inferred because {1} expressions aren't supported.",
       "Try adding an explicit type for '{0}'.");