Convert top-level inference errors to hints

pkg/analyzer/test/generated/hint_code_test.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library analyzer.test.generated.hint_code_test;
 
 import 'package:analyzer/error/error.dart';
 import 'package:analyzer/src/error/codes.dart';
 import 'package:analyzer/src/generated/engine.dart';
 import 'package:analyzer/src/generated/parser.dart';
@@ skipping 2481 matching lines @@
 
 class C {
   F m() => ({@required String x}) => null;
 }
 ''');
     await computeAnalysisResult(source);
     assertErrors(source, [HintCode.MISSING_REQUIRED_PARAM]);
     verify([source]);
   }
 
-  test_strongMode_downCastCompositeNoHint() async {
+  test_strongMode_downCastCompositeHint() async {
     AnalysisOptionsImpl options = new AnalysisOptionsImpl();
     options.strongMode = true;
-    options.strongModeHints = false;
+    options.strongModeHints = true;
     resetWith(options: options);
     Source source = addSource(r'''
 main() {
   List dynamicList = [ ];
   List<int> list = dynamicList;
   print(list);
 }''');
     await computeAnalysisResult(source);
-    assertNoErrors(source);
+    assertErrors(source, [StrongModeCode.DOWN_CAST_COMPOSITE]);
     verify([source]);
   }
 
-  test_strongMode_downCastCompositeHint() async {
+  test_strongMode_downCastCompositeNoHint() async {
     AnalysisOptionsImpl options = new AnalysisOptionsImpl();
     options.strongMode = true;
-    options.strongModeHints = true;
+    options.strongModeHints = false;
     resetWith(options: options);
     Source source = addSource(r'''
 main() {
   List dynamicList = [ ];
   List<int> list = dynamicList;
   print(list);
 }''');
     await computeAnalysisResult(source);
-    assertErrors(source, [StrongModeCode.DOWN_CAST_COMPOSITE]);
+    assertNoErrors(source);
     verify([source]);
   }
 
   test_strongMode_downCastCompositeWarn() async {
     AnalysisOptionsImpl options = new AnalysisOptionsImpl();
     applyToAnalysisOptions(options, {
       AnalyzerOptions.analyzer: {
         AnalyzerOptions.errors: {
           StrongModeCode.DOWN_CAST_COMPOSITE.name: 'warning'
         },
       }
     });
     options.strongMode = true;
     options.strongModeHints = false;
     resetWith(options: options);
     Source source = addSource(r'''
 main() {
   List dynamicList = [ ];
   List<int> list = dynamicList;
   print(list);
 }''');
     await computeAnalysisResult(source);
     assertErrors(source, [StrongModeCode.DOWN_CAST_COMPOSITE]);
     verify([source]);
   }
 
+  test_strongMode_topLevelInstanceGetter() async {
+    resetWith(options: new AnalysisOptionsImpl()..strongMode = true);
+    Source source = addSource(r'''
+class A {
+  int get g => 0;
+}
+var a = new A();
+var b = a.g;
+''');
+    await computeAnalysisResult(source);
+    assertErrors(source, [StrongModeCode.TOP_LEVEL_INSTANCE_GETTER]);
+    verify([source]);
+  }
+
   test_typeCheck_type_is_Null() async {
     Source source = addSource(r'''
 m(i) {
   bool b = i is Null;
 }''');
     await computeAnalysisResult(source);
     assertErrors(source, [HintCode.TYPE_CHECK_IS_NULL]);
     verify([source]);
   }
 
@@ skipping 1641 matching lines @@
   n() {
     var a = m(), b = m();
   }
 }''');
     await computeAnalysisResult(source);
     assertErrors(
         source, [HintCode.USE_OF_VOID_RESULT, HintCode.USE_OF_VOID_RESULT]);
     verify([source]);
   }
 }