Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Unified Diff: pkg/analyzer/test/src/task/strong/strong_test_helper.dart

Issue 2786993002: Convert top-level inference errors to hints (Closed)
Patch Set: Preserve the new hints Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/test/src/task/strong/strong_test_helper.dart
diff --git a/pkg/analyzer/test/src/task/strong/strong_test_helper.dart b/pkg/analyzer/test/src/task/strong/strong_test_helper.dart
index dddce076a27577ce1f2abebc618266b6198165fe..77f38a3a5447654db5fc0d7b205e505b0c7ed8f8 100644
--- a/pkg/analyzer/test/src/task/strong/strong_test_helper.dart
+++ b/pkg/analyzer/test/src/task/strong/strong_test_helper.dart
@@ -67,6 +67,11 @@ String _errorCodeName(ErrorCode errorCode) {
ErrorSeverity _errorSeverity(
AnalysisOptions analysisOptions, AnalysisError error) {
+ // TODO(brianwilkerson) Remove the if when top-level inference is made an
+ // error again.
+ if (error.errorCode.name.startsWith('STRONG_MODE_TOP_LEVEL_')) {
+ return ErrorSeverity.ERROR;
+ }
return ErrorProcessor.getProcessor(analysisOptions, error)?.severity ??
error.errorCode.errorSeverity;
}

Powered by Google App Engine
This is Rietveld 408576698