Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 2786643003: Implement support for the 'transform-box' property (Closed)

Created:
3 years, 8 months ago by fs
Modified:
3 years, 8 months ago
Reviewers:
pdr., Ilya Sherman
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-frames_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, krit, fmalita+watch_chromium.org, gyuyoung2, kinuko+watch, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement support for the 'transform-box' property Spec: https://drafts.csswg.org/css-transforms-1/#transform-box Intent to implement: https://groups.google.com/a/chromium.org/d/topic/blink-dev/v8g3QF8pRF8 Implemented behind the CSSTransformBox Blink runtime flag. Add some basic tests and a smoke test for the "legacy" transform-box behavior. Existing tests are adjusted to be compatible with the new behavior. The test svg/transforms/transform-origin-css-property.xhtml is "fixed" by adding units when required (unitless numbers are not valid in inline style.) BUG=595829 Review-Url: https://codereview.chromium.org/2786643003 Cr-Commit-Position: refs/heads/master@{#462266} Committed: https://chromium.googlesource.com/chromium/src/+/8e4a41274d2916c25668c2e7c37892e878e5d6c4

Patch Set 1 #

Patch Set 2 : Fix computed style mapping. Fix virtual testsuite. #

Patch Set 3 : Update existing tests to be compatible #

Total comments: 4

Patch Set 4 : Rebase; fix property spec; update histogram.xml #

Unified diffs Side-by-side diffs Delta from patch set Stats (+226 lines, -21 lines) Patch
M third_party/WebKit/LayoutTests/VirtualTestSuites View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/css/transform-origin-zoom.svg View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/transforms/change-transform-origin-css.xhtml View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/svg/transforms/change-transform-origin-presentation-attribute.xhtml View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/svg/transforms/percent-transform-values.xhtml View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/svg/transforms/transform-box-border-box.html View 1 chunk +29 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/svg/transforms/transform-box-border-box-expected.html View 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/svg/transforms/transform-box-fill-box.html View 1 chunk +29 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/svg/transforms/transform-box-fill-box-expected.html View 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/svg/transforms/transform-box-view-box.html View 1 chunk +29 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/svg/transforms/transform-box-view-box-expected.html View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/transforms/transform-origin-css-property.xhtml View 1 2 2 chunks +8 lines, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/virtual/stable/svg/transforms/stable/README.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/stable/svg/transforms/stable/legacy-transform-box.html View 1 1 chunk +44 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/css-properties-as-js-properties-expected.txt View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSProperties.json5 View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSValueKeywords.json5 View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.cpp View 1 2 3 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.cpp View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.cpp View 1 2 3 1 chunk +4 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGElement.cpp View 4 chunks +32 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5 View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 3 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 33 (24 generated)
fs
3 years, 8 months ago (2017-03-30 20:28:35 UTC) #17
fs
On 2017/03/30 at 20:28:35, fs wrote: > Ping.
3 years, 8 months ago (2017-04-04 12:02:31 UTC) #18
pdr.
LGTM https://codereview.chromium.org/2786643003/diff/40001/third_party/WebKit/Source/core/css/CSSProperties.json5 File third_party/WebKit/Source/core/css/CSSProperties.json5 (right): https://codereview.chromium.org/2786643003/diff/40001/third_party/WebKit/Source/core/css/CSSProperties.json5#newcode1929 third_party/WebKit/Source/core/css/CSSProperties.json5:1929: initial_keyword: "border-box", Because I took forever to review ...
3 years, 8 months ago (2017-04-04 22:47:13 UTC) #19
pdr.
On 2017/04/04 at 12:02:31, fs wrote: > On 2017/03/30 at 20:28:35, fs wrote: > > ...
3 years, 8 months ago (2017-04-04 22:56:21 UTC) #20
fs
On 2017/04/04 at 22:56:21, pdr wrote: > On 2017/04/04 at 12:02:31, fs wrote: > > ...
3 years, 8 months ago (2017-04-05 08:48:17 UTC) #21
fs
+isherman for histograms.xml
3 years, 8 months ago (2017-04-05 21:39:34 UTC) #25
Ilya Sherman
histograms.xml lgtm
3 years, 8 months ago (2017-04-05 21:44:20 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2786643003/60001
3 years, 8 months ago (2017-04-05 22:08:04 UTC) #30
commit-bot: I haz the power
3 years, 8 months ago (2017-04-05 23:24:03 UTC) #33
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/8e4a41274d2916c25668c2e7c378...

Powered by Google App Engine
This is Rietveld 408576698