Implement support for the 'transform-box' property

Implement support for the 'transform-box' property

Spec:

 https://drafts.csswg.org/css-transforms-1/#transform-box

Intent to implement:

 https://groups.google.com/a/chromium.org/d/topic/blink-dev/v8g3QF8pRF8

Implemented behind the CSSTransformBox Blink runtime flag.
Add some basic tests and a smoke test for the "legacy" transform-box
behavior. Existing tests are adjusted to be compatible with the new
behavior.
The test svg/transforms/transform-origin-css-property.xhtml is "fixed"
by adding units when required (unitless numbers are not valid in inline
style.)

BUG=595829
Review-Url: https://codereview.chromium.org/2786643003
Cr-Commit-Position: refs/heads/master@{#462266}
Committed: https://chromium.googlesource.com/chromium/src/+/8e4a41274d2916c25668c2e7c37892e878e5d6c4

[fs, 2017-03-29 16:03:11]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 16:04:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 17:06:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 17:06:35]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[fs, 2017-03-30 12:03:56]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-30 12:04:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fs, 2017-03-30 12:19:39]

Description was changed from

==========
Implement support for the 'transform-box' property

Spec:

 https://drafts.csswg.org/css-transforms-1/#transform-box

Implemented behind the CSSTransformBox Blink runtime flag.
Add some basic tests and a smoke test for the "legacy" transform-box
behavior.

BUG=595829
==========

to

==========
Implement support for the 'transform-box' property

Spec:

 https://drafts.csswg.org/css-transforms-1/#transform-box

Implemented behind the CSSTransformBox Blink runtime flag.
Add some basic tests and a smoke test for the "legacy" transform-box
behavior.

Intent to implement:

 https://groups.google.com/a/chromium.org/d/topic/blink-dev/v8g3QF8pRF8

BUG=595829
==========

[fs, 2017-03-30 12:19:51]

Description was changed from

==========
Implement support for the 'transform-box' property

Spec:

 https://drafts.csswg.org/css-transforms-1/#transform-box

Implemented behind the CSSTransformBox Blink runtime flag.
Add some basic tests and a smoke test for the "legacy" transform-box
behavior.

Intent to implement:

 https://groups.google.com/a/chromium.org/d/topic/blink-dev/v8g3QF8pRF8

BUG=595829
==========

to

==========
Implement support for the 'transform-box' property

Spec:

 https://drafts.csswg.org/css-transforms-1/#transform-box

Intent to implement:

 https://groups.google.com/a/chromium.org/d/topic/blink-dev/v8g3QF8pRF8

Implemented behind the CSSTransformBox Blink runtime flag.
Add some basic tests and a smoke test for the "legacy" transform-box
behavior.

BUG=595829
==========

[commit-bot: I haz the power, 2017-03-30 13:34:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 13:34:32]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[fs, 2017-03-30 14:18:02]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-30 14:18:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fs, 2017-03-30 14:26:25]

Description was changed from

==========
Implement support for the 'transform-box' property

Spec:

 https://drafts.csswg.org/css-transforms-1/#transform-box

Intent to implement:

 https://groups.google.com/a/chromium.org/d/topic/blink-dev/v8g3QF8pRF8

Implemented behind the CSSTransformBox Blink runtime flag.
Add some basic tests and a smoke test for the "legacy" transform-box
behavior.

BUG=595829
==========

to

==========
Implement support for the 'transform-box' property

Spec:

 https://drafts.csswg.org/css-transforms-1/#transform-box

Intent to implement:

 https://groups.google.com/a/chromium.org/d/topic/blink-dev/v8g3QF8pRF8

Implemented behind the CSSTransformBox Blink runtime flag.
Add some basic tests and a smoke test for the "legacy" transform-box
behavior. Existing tests are adjusted to be compatible with the new
behavior.
The test svg/transforms/transform-origin-css-property.xhtml is "fixed"
by adding units when required (unitless numbers are not valid in inline
style.)

BUG=595829
==========

[commit-bot: I haz the power, 2017-03-30 16:30:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 16:30:02]

Dry run: This issue passed the CQ dry run.

[fs, 2017-03-30 20:28:35]

fs@opera.com changed reviewers:
+ pdr@chromium.org

[fs, 2017-04-04 12:02:31]

On 2017/03/30 at 20:28:35, fs wrote:
> 

Ping.

[pdr., 2017-04-04 22:47:13]

LGTM

https://codereview.chromium.org/2786643003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/CSSProperties.json5 (right):

https://codereview.chromium.org/2786643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/CSSProperties.json5:1929: initial_keyword:
"border-box",
Because I took forever to review this, something changed in the format. I think
this now needs to be default_value.

https://codereview.chromium.org/2786643003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/svg/SVGElement.cpp (right):

https://codereview.chromium.org/2786643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/svg/SVGElement.cpp:333: if (style.transformBox()
== ETransformBox::kFillBox)
I was looking at Gecko's implementation and they also just have two cases:
fill-box and not-fill-box:
https://bug923193.bmoattachments.org/attachment.cgi?id=8607931. Do you know why
the spec has both kBorderBox and kViewBox?

[pdr., 2017-04-04 22:56:21]

On 2017/04/04 at 12:02:31, fs wrote:
> On 2017/03/30 at 20:28:35, fs wrote:
> > 
> 
> Ping.

I'm sorry but I went radio-silence for a week with a terrible flu :(

[fs, 2017-04-05 08:48:17]

On 2017/04/04 at 22:56:21, pdr wrote:
> On 2017/04/04 at 12:02:31, fs wrote:
> > On 2017/03/30 at 20:28:35, fs wrote:
> > > 
> > 
> > Ping.
> 
> I'm sorry but I went radio-silence for a week with a terrible flu :(

Ouch, flu isn't fun =(.

https://codereview.chromium.org/2786643003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/CSSProperties.json5 (right):

https://codereview.chromium.org/2786643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/CSSProperties.json5:1929: initial_keyword:
"border-box",
On 2017/04/04 at 22:47:13, pdr - OOO until April 9 wrote:
> Because I took forever to review this, something changed in the format. I
think this now needs to be default_value.

Will fix.

https://codereview.chromium.org/2786643003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/svg/SVGElement.cpp (right):

https://codereview.chromium.org/2786643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/svg/SVGElement.cpp:333: if (style.transformBox()
== ETransformBox::kFillBox)
On 2017/04/04 at 22:47:13, pdr - OOO until April 9 wrote:
> I was looking at Gecko's implementation and they also just have two cases:
fill-box and not-fill-box:
https://bug923193.bmoattachments.org/attachment.cgi?id=8607931. Do you know why
the spec has both kBorderBox and kViewBox?

I've not managed to find any relevant minutes about this ([1] hints there was
discussion), so I can only guess. Maybe because 'border-box' is a weird
(non-obvious) value for what it does (for SVG), so the "alias" 'view-box' is
better suited?

[1] https://lists.w3.org/Archives/Public/www-style/2014Nov/0000.html

[fs, 2017-04-05 20:42:42]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 20:43:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fs, 2017-04-05 21:39:33]

fs@opera.com changed reviewers:
+ isherman@chromium.org

[fs, 2017-04-05 21:39:34]

+isherman for histograms.xml

[Ilya Sherman, 2017-04-05 21:44:20]

histograms.xml lgtm

[fs, 2017-04-05 22:07:02]

The CQ bit was unchecked by fs@opera.com

[fs, 2017-04-05 22:07:25]

The CQ bit was checked by fs@opera.com

[fs, 2017-04-05 22:07:26]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/2786643003/#ps60001
(title: "Rebase; fix property spec; update histogram.xml")

[commit-bot: I haz the power, 2017-04-05 22:08:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 23:23:00]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1491430045612960,
"parent_rev": "2a567808f0a58c27d84845c8c178f33e79a1426b", "commit_rev":
"8e4a41274d2916c25668c2e7c37892e878e5d6c4"}

[commit-bot: I haz the power, 2017-04-05 23:23:56]

Description was changed from

==========
Implement support for the 'transform-box' property

Spec:

 https://drafts.csswg.org/css-transforms-1/#transform-box

Intent to implement:

 https://groups.google.com/a/chromium.org/d/topic/blink-dev/v8g3QF8pRF8

Implemented behind the CSSTransformBox Blink runtime flag.
Add some basic tests and a smoke test for the "legacy" transform-box
behavior. Existing tests are adjusted to be compatible with the new
behavior.
The test svg/transforms/transform-origin-css-property.xhtml is "fixed"
by adding units when required (unitless numbers are not valid in inline
style.)

BUG=595829
==========

to

==========
Implement support for the 'transform-box' property

Spec:

 https://drafts.csswg.org/css-transforms-1/#transform-box

Intent to implement:

 https://groups.google.com/a/chromium.org/d/topic/blink-dev/v8g3QF8pRF8

Implemented behind the CSSTransformBox Blink runtime flag.
Add some basic tests and a smoke test for the "legacy" transform-box
behavior. Existing tests are adjusted to be compatible with the new
behavior.
The test svg/transforms/transform-origin-css-property.xhtml is "fixed"
by adding units when required (unitless numbers are not valid in inline
style.)

BUG=595829

Review-Url: https://codereview.chromium.org/2786643003
Cr-Commit-Position: refs/heads/master@{#462266}
Committed:
https://chromium.googlesource.com/chromium/src/+/8e4a41274d2916c25668c2e7c378...
==========

[commit-bot: I haz the power, 2017-04-05 23:24:03]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/8e4a41274d2916c25668c2e7c378...