Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Side by Side Diff: third_party/WebKit/Source/core/frame/UseCounter.cpp

Issue 2786643003: Implement support for the 'transform-box' property (Closed)
Patch Set: Rebase; fix property spec; update histogram.xml Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google, Inc. All rights reserved. 2 * Copyright (C) 2012 Google, Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 28 matching lines...) Expand all
39 #include "platform/instrumentation/tracing/TraceEvent.h" 39 #include "platform/instrumentation/tracing/TraceEvent.h"
40 #include "platform/weborigin/SchemeRegistry.h" 40 #include "platform/weborigin/SchemeRegistry.h"
41 41
42 namespace { 42 namespace {
43 43
44 int totalPagesMeasuredCSSSampleId() { 44 int totalPagesMeasuredCSSSampleId() {
45 return 1; 45 return 1;
46 } 46 }
47 47
48 // Make sure update_use_counter_css.py was run which updates histograms.xml. 48 // Make sure update_use_counter_css.py was run which updates histograms.xml.
49 constexpr int kMaximumCSSSampleId = 558; 49 constexpr int kMaximumCSSSampleId = 559;
50 50
51 } // namespace 51 } // namespace
52 52
53 namespace blink { 53 namespace blink {
54 54
55 int UseCounter::mapCSSPropertyIdToCSSSampleIdForHistogram( 55 int UseCounter::mapCSSPropertyIdToCSSSampleIdForHistogram(
56 CSSPropertyID cssPropertyID) { 56 CSSPropertyID cssPropertyID) {
57 switch (cssPropertyID) { 57 switch (cssPropertyID) {
58 // Begin at 2, because 1 is reserved for totalPagesMeasuredCSSSampleId. 58 // Begin at 2, because 1 is reserved for totalPagesMeasuredCSSSampleId.
59 case CSSPropertyColor: 59 case CSSPropertyColor:
(...skipping 1018 matching lines...) Expand 10 before | Expand all | Expand 10 after
1078 case CSSPropertyMaxInlineSize: 1078 case CSSPropertyMaxInlineSize:
1079 return 554; 1079 return 554;
1080 case CSSPropertyMaxBlockSize: 1080 case CSSPropertyMaxBlockSize:
1081 return 555; 1081 return 555;
1082 case CSSPropertyAliasLineBreak: 1082 case CSSPropertyAliasLineBreak:
1083 return 556; 1083 return 556;
1084 case CSSPropertyPlaceContent: 1084 case CSSPropertyPlaceContent:
1085 return 557; 1085 return 557;
1086 case CSSPropertyPlaceItems: 1086 case CSSPropertyPlaceItems:
1087 return 558; 1087 return 558;
1088 case CSSPropertyTransformBox:
1089 return 559;
1088 // 1. Add new features above this line (don't change the assigned numbers of 1090 // 1. Add new features above this line (don't change the assigned numbers of
1089 // the existing items). 1091 // the existing items).
1090 // 2. Update kMaximumCSSSampleId with the new maximum value. 1092 // 2. Update kMaximumCSSSampleId with the new maximum value.
1091 // 3. Run the update_use_counter_css.py script in 1093 // 3. Run the update_use_counter_css.py script in
1092 // chromium/src/tools/metrics/histograms to update the UMA histogram names. 1094 // chromium/src/tools/metrics/histograms to update the UMA histogram names.
1093 1095
1094 case CSSPropertyInvalid: 1096 case CSSPropertyInvalid:
1095 ASSERT_NOT_REACHED(); 1097 ASSERT_NOT_REACHED();
1096 return 0; 1098 return 0;
1097 } 1099 }
(...skipping 313 matching lines...) Expand 10 before | Expand all | Expand 10 after
1411 } 1413 }
1412 } 1414 }
1413 1415
1414 if (needsPagesMeasuredUpdate) 1416 if (needsPagesMeasuredUpdate)
1415 cssPropertiesHistogram.count(totalPagesMeasuredCSSSampleId()); 1417 cssPropertiesHistogram.count(totalPagesMeasuredCSSSampleId());
1416 1418
1417 m_CSSBits.clearAll(); 1419 m_CSSBits.clearAll();
1418 } 1420 }
1419 1421
1420 } // namespace blink 1422 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698