Use EphemeralRange instead of Range in Range::isNodeFullyContainded

Use EphemeralRange instead of Range in Range::isNodeFullyContainded

This patch redefines Range::isNodeFullyContainded(Node) as
 EditingUtilities::isNodeFullyContained(EphemeralRange, Node)

BUG=388681
Review-Url: https://codereview.chromium.org/2786573002
Cr-Commit-Position: refs/heads/master@{#460382}
Committed: https://chromium.googlesource.com/chromium/src/+/e7405101101410fd1ca1302ba7242a717d16aacb

[yoichio, 2017-03-29 04:32:38]

The CQ bit was checked by yoichio@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 04:33:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yoichio, 2017-03-29 05:49:44]

Description was changed from

==========
Use EphemeralRange instead of Range in isNodeFullyContainded

BUG=388681
==========

to

==========
Use EphemeralRange instead of Range in Range::isNodeFullyContainded

This patch redefines Range::isNodeFullyContainded(Node) as
 EditingUtilities::isNodeFullyContained(EphemeralRange, Node)

BUG=388681
==========

[yoichio, 2017-03-29 05:49:44]

yoichio@chromium.org changed reviewers:
+ yosin@chromium.org

[yoichio, 2017-03-29 06:17:36]

The CQ bit was checked by yoichio@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 06:17:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-03-29 07:18:43]

lgtm w/ nit

Good catch!

https://codereview.chromium.org/2786573002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/EditingUtilities.cpp (right):

https://codereview.chromium.org/2786573002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/EditingUtilities.cpp:303: return
comparePositions(range.startPosition(), Position::beforeNode(&node)) <=
nit: We can use Position::operator<=(), which is a wrapper of
comparePositions(), here

range.startPosition() <= Position::beforeNode(&node) && ...

[commit-bot: I haz the power, 2017-03-29 07:24:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 07:24:55]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[yoichio, 2017-03-29 07:42:20]

https://codereview.chromium.org/2786573002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/EditingUtilities.cpp (right):

https://codereview.chromium.org/2786573002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/EditingUtilities.cpp:303: return
comparePositions(range.startPosition(), Position::beforeNode(&node)) <=
On 2017/03/29 07:18:42, yosin_UTC9 wrote:
> nit: We can use Position::operator<=(), which is a wrapper of
> comparePositions(), here
> 
> range.startPosition() <= Position::beforeNode(&node) && ...

Done.

[yoichio, 2017-03-29 07:42:23]

The CQ bit was checked by yoichio@chromium.org

[yoichio, 2017-03-29 07:42:23]

The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org
Link to the patchset: https://codereview.chromium.org/2786573002/#ps40001
(title: "update")

[commit-bot: I haz the power, 2017-03-29 07:42:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 07:50:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 07:50:02]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[yoichio, 2017-03-29 08:59:06]

yoichio@chromium.org changed reviewers:
+ tkent@chromium.org

[yoichio, 2017-03-29 08:59:07]

kent, PTAL as owner.

[tkent, 2017-03-29 09:02:17]

lgtm

https://codereview.chromium.org/2786573002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/EditingUtilities.cpp (right):

https://codereview.chromium.org/2786573002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/EditingUtilities.cpp:296: bool
isNodeFullyContained(const EphemeralRange& range, Node& node) {
The second argument should be |const Node&|.

[yoichio, 2017-03-29 09:25:40]

https://codereview.chromium.org/2786573002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/EditingUtilities.cpp (right):

https://codereview.chromium.org/2786573002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/EditingUtilities.cpp:296: bool
isNodeFullyContained(const EphemeralRange& range, Node& node) {
On 2017/03/29 09:02:17, tkent wrote:
> The second argument should be |const Node&|.

Yes, but Position has non-const Member<Node>.

[tkent, 2017-03-29 10:39:51]

https://codereview.chromium.org/2786573002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/EditingUtilities.cpp (right):

https://codereview.chromium.org/2786573002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/EditingUtilities.cpp:296: bool
isNodeFullyContained(const EphemeralRange& range, Node& node) {
On 2017/03/29 at 09:25:40, yoichio wrote:
> On 2017/03/29 09:02:17, tkent wrote:
> > The second argument should be |const Node&|.
> 
> Yes, but Position has non-const Member<Node>.

Oh, I see.  Please go ahead landing.

[yoichio1, 2017-03-29 13:02:10]

The CQ bit was checked by yoichio@google.com

[commit-bot: I haz the power, 2017-03-29 13:02:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 14:45:02]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490792530770500,
"parent_rev": "3056319cc7510415c98bb98e2529dfbcb1d973c4", "commit_rev":
"e7405101101410fd1ca1302ba7242a717d16aacb"}

[commit-bot: I haz the power, 2017-03-29 14:45:47]

Description was changed from

==========
Use EphemeralRange instead of Range in Range::isNodeFullyContainded

This patch redefines Range::isNodeFullyContainded(Node) as
 EditingUtilities::isNodeFullyContained(EphemeralRange, Node)

BUG=388681
==========

to

==========
Use EphemeralRange instead of Range in Range::isNodeFullyContainded

This patch redefines Range::isNodeFullyContainded(Node) as
 EditingUtilities::isNodeFullyContained(EphemeralRange, Node)

BUG=388681

Review-Url: https://codereview.chromium.org/2786573002
Cr-Commit-Position: refs/heads/master@{#460382}
Committed:
https://chromium.googlesource.com/chromium/src/+/e7405101101410fd1ca1302ba724...
==========

[commit-bot: I haz the power, 2017-03-29 14:45:48]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/e7405101101410fd1ca1302ba724...