Use EphemeralRange instead of Range in Range::isNodeFullyContainded

third_party/WebKit/Source/core/editing/EditingUtilities.cpp

 /*
  * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 275 matching lines @@
 
 int comparePositions(const PositionWithAffinity& a,
                      const PositionWithAffinity& b) {
   return comparePositions(a.position(), b.position());
 }
 
 int comparePositions(const VisiblePosition& a, const VisiblePosition& b) {
   return comparePositions(a.deepEquivalent(), b.deepEquivalent());
 }
 
+bool isNodeFullyContained(const EphemeralRange& range, Node& node) {

[tkent, 2017/03/29 09:02:17]

The second argument should be |const Node&|.

[yoichio, 2017/03/29 09:25:40]

Yes, but Position has non-const Member<Node>.

[tkent, 2017/03/29 10:39:51]

Oh, I see.  Please go ahead landing.

+  if (range.isNull())
+    return false;
+
+  if (!NodeTraversal::commonAncestor(*range.startPosition().anchorNode(), node))
+    return false;
+
+  return range.startPosition() <= Position::beforeNode(&node) &&
+         Position::afterNode(&node) <= range.endPosition();
+}
+
 // TODO(editing-dev): We should implement real version which refers
 // "user-select" CSS property.
 // TODO(editing-dev): We should make |SelectionAdjuster| to use this funciton
 // instead of |isSelectionBondary()|.
 bool isUserSelectContain(const Node& node) {
   return isHTMLTextAreaElement(node) || isHTMLInputElement(node) ||
          isHTMLSelectElement(node);
 }
 
 enum EditableLevel { Editable, RichlyEditable };
@@ skipping 1837 matching lines @@
         return InputType::DeleteWordBackward;
       if (granularity == LineBoundary)
         return InputType::DeleteLineBackward;
       return InputType::DeleteContentBackward;
     default:
       return InputType::None;
   }
 }
 
 }  // namespace blink