Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Side by Side Diff: third_party/WebKit/Source/core/editing/EditingUtilities.h

Issue 2786573002: Use EphemeralRange instead of Range in Range::isNodeFullyContainded (Closed)
Patch Set: update Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2006, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2004, 2006, 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 253 matching lines...) Expand 10 before | Expand all | Expand 10 after
264 bool* disconnected = nullptr); 264 bool* disconnected = nullptr);
265 int comparePositionsInFlatTree(Node* containerA, 265 int comparePositionsInFlatTree(Node* containerA,
266 int offsetA, 266 int offsetA,
267 Node* containerB, 267 Node* containerB,
268 int offsetB, 268 int offsetB,
269 bool* disconnected = nullptr); 269 bool* disconnected = nullptr);
270 // TODO(yosin): We replace |comparePositions()| by |Position::opeator<()| to 270 // TODO(yosin): We replace |comparePositions()| by |Position::opeator<()| to
271 // utilize |DCHECK_XX()|. 271 // utilize |DCHECK_XX()|.
272 int comparePositions(const Position&, const Position&); 272 int comparePositions(const Position&, const Position&);
273 int comparePositions(const PositionWithAffinity&, const PositionWithAffinity&); 273 int comparePositions(const PositionWithAffinity&, const PositionWithAffinity&);
274 bool isNodeFullyContained(const EphemeralRange&, Node&);
274 275
275 // boolean functions on Position 276 // boolean functions on Position
276 277
277 // FIXME: Both isEditablePosition and isRichlyEditablePosition rely on 278 // FIXME: Both isEditablePosition and isRichlyEditablePosition rely on
278 // up-to-date style to give proper results. They shouldn't update style by 279 // up-to-date style to give proper results. They shouldn't update style by
279 // default, but should make it clear that that is the contract. 280 // default, but should make it clear that that is the contract.
280 CORE_EXPORT bool isEditablePosition(const Position&); 281 CORE_EXPORT bool isEditablePosition(const Position&);
281 bool isEditablePosition(const PositionInFlatTree&); 282 bool isEditablePosition(const PositionInFlatTree&);
282 bool isRichlyEditablePosition(const Position&); 283 bool isRichlyEditablePosition(const Position&);
283 bool lineBreakExistsAtPosition(const Position&); 284 bool lineBreakExistsAtPosition(const Position&);
(...skipping 148 matching lines...) Expand 10 before | Expand all | Expand 10 after
432 DispatchEventResult dispatchBeforeInputDataTransfer(Node*, 433 DispatchEventResult dispatchBeforeInputDataTransfer(Node*,
433 InputEvent::InputType, 434 InputEvent::InputType,
434 DataTransfer*); 435 DataTransfer*);
435 436
436 InputEvent::InputType deletionInputTypeFromTextGranularity(DeleteDirection, 437 InputEvent::InputType deletionInputTypeFromTextGranularity(DeleteDirection,
437 TextGranularity); 438 TextGranularity);
438 439
439 } // namespace blink 440 } // namespace blink
440 441
441 #endif 442 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698