Add links to more options pages for Chrome OS accessibility features

Add links to more options pages for Chrome OS accessibility features

When Select-to-speak or Switch access are enabled, this gives them an
icon to open their options pages. (These are both still behind a flag.)

Also fixes the icon for all three (those two plus ChromeVox) to be a
settings icon rather than a generic link icon.

BUG=676449
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2786453002
Cr-Commit-Position: refs/heads/master@{#460860}
Committed: https://chromium.googlesource.com/chromium/src/+/ae80cc54f9647790978bb123786719eec071ce82

[dmazzoni, 2017-03-28 21:23:02]

Description was changed from

==========
Add links to more options pages for Chrome OS accessibility features

When Select-to-speak or Switch access are enabled, this gives them an
icon to open their options pages. (These are both still behind a flag.)

Also fixes the icon for all three (those two plus ChromeVox) to be a
settings icon rather than a generic link icon.

BUG=676449
==========

to

==========
Add links to more options pages for Chrome OS accessibility features

When Select-to-speak or Switch access are enabled, this gives them an
icon to open their options pages. (These are both still behind a flag.)

Also fixes the icon for all three (those two plus ChromeVox) to be a
settings icon rather than a generic link icon.

BUG=676449
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dmazzoni, 2017-03-28 21:23:12]

The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 21:23:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 21:23:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 21:23:27]

Dry run: CQ has no permission to schedule in bucket
master.tryserver.chromium.linux

[dmazzoni, 2017-03-28 21:23:32]

dmazzoni@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2017-03-29 13:22:45]

https://codereview.chromium.org/2786453002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/a11y_page/manage_a11y_page.html (right):

https://codereview.chromium.org/2786453002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/a11y_page/manage_a11y_page.html:48:
aria-label="$i18n{chromeVoxOptionsLabel}"></paper-icon-button>
does clicking the settings icon also trigger flipping the toggle button?

https://codereview.chromium.org/2786453002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/a11y_page/manage_a11y_page.js (right):

https://codereview.chromium.org/2786453002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/a11y_page/manage_a11y_page.js:74:
chrome.send('showSelectToSpeakSettings');
these should eventually be in a "browser proxy"

[dmazzoni, 2017-03-29 15:12:50]

https://codereview.chromium.org/2786453002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/a11y_page/manage_a11y_page.html (right):

https://codereview.chromium.org/2786453002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/a11y_page/manage_a11y_page.html:48:
aria-label="$i18n{chromeVoxOptionsLabel}"></paper-icon-button>
On 2017/03/29 13:22:44, Dan Beam (slow) wrote:
> does clicking the settings icon also trigger flipping the toggle button?

No, because it's hidden when the toggle is off:
hidden="[[!prefs.settings.accessibility.value]]"

https://codereview.chromium.org/2786453002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/a11y_page/manage_a11y_page.js (right):

https://codereview.chromium.org/2786453002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/a11y_page/manage_a11y_page.js:74:
chrome.send('showSelectToSpeakSettings');
On 2017/03/29 13:22:44, Dan Beam (slow) wrote:
> these should eventually be in a "browser proxy"

Can I do that now? Is there an example of another settings page
that moved to a browser proxy that I could follow?

[Dan Beam, 2017-03-29 23:35:04]

lgtm

https://codereview.chromium.org/2786453002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/a11y_page/manage_a11y_page.js (right):

https://codereview.chromium.org/2786453002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/a11y_page/manage_a11y_page.js:74:
chrome.send('showSelectToSpeakSettings');
On 2017/03/29 15:12:50, dmazzoni wrote:
> On 2017/03/29 13:22:44, Dan Beam (slow) wrote:
> > these should eventually be in a "browser proxy"
> 
> Can I do that now? Is there an example of another settings page
> that moved to a browser proxy that I could follow?

almost all other pages create an @interface and implement it with a concrete in
the prod code. look for a _browser_proxy.js.

in test code it's then easy to set or inject a test double (typically fakes or
mocks)

[dmazzoni, 2017-03-30 18:37:16]

The CQ bit was checked by dmazzoni@chromium.org

[commit-bot: I haz the power, 2017-03-30 18:37:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 20:01:36]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490899036990450, "parent_rev":
"4d5b2df34c2023956579d96e89aaaacf04e510d1", "commit_rev":
"ae80cc54f9647790978bb123786719eec071ce82"}

[commit-bot: I haz the power, 2017-03-30 20:02:24]

Description was changed from

==========
Add links to more options pages for Chrome OS accessibility features

When Select-to-speak or Switch access are enabled, this gives them an
icon to open their options pages. (These are both still behind a flag.)

Also fixes the icon for all three (those two plus ChromeVox) to be a
settings icon rather than a generic link icon.

BUG=676449
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Add links to more options pages for Chrome OS accessibility features

When Select-to-speak or Switch access are enabled, this gives them an
icon to open their options pages. (These are both still behind a flag.)

Also fixes the icon for all three (those two plus ChromeVox) to be a
settings icon rather than a generic link icon.

BUG=676449
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2786453002
Cr-Commit-Position: refs/heads/master@{#460860}
Committed:
https://chromium.googlesource.com/chromium/src/+/ae80cc54f9647790978bb1237867...
==========

[commit-bot: I haz the power, 2017-03-30 20:02:25]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ae80cc54f9647790978bb1237867...