Add i18n support to Select-to-speak

Add i18n support to Select-to-speak

BUG=593887
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2775303004
Cr-Commit-Position: refs/heads/master@{#461071}
Committed: https://chromium.googlesource.com/chromium/src/+/259d50c77c3e2b8a9a8bcc94cc8fef215aa69b27

[dmazzoni, 2017-03-28 23:28:16]

Description was changed from

==========
Add i18n support to Select-to-speak

BUG=593887
==========

to

==========
Add i18n support to Select-to-speak

BUG=593887
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dmazzoni, 2017-03-29 05:56:08]

dmazzoni@chromium.org changed reviewers:
+ dtseng@chromium.org

[David Tseng, 2017-03-29 22:04:43]

lgtm

https://codereview.chromium.org/2775303004/diff/1/chrome/browser/resources/ch...
File
chrome/browser/resources/chromeos/select_to_speak/strings/select_to_speak_strings.grd
(right):

https://codereview.chromium.org/2775303004/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/select_to_speak/strings/select_to_speak_strings.grd:124:
Hold down Search and click or drag to speak anything.
does dragging cause speech output?
Maybe something like hold search, and select what to speak with the mouse

[dmazzoni, 2017-03-29 23:26:43]

dmazzoni@chromium.org changed reviewers:
+ thestig@chromium.org

[dmazzoni, 2017-03-29 23:26:43]

+thestig for grit

[Lei Zhang, 2017-03-30 00:33:42]

Does this work without an entry in tools/gritsettings/resource_ids ?

[dmazzoni, 2017-03-30 18:41:29]

On 2017/03/30 00:33:42, Lei Zhang wrote:
> Does this work without an entry in tools/gritsettings/resource_ids ?

I think so because these strings are used to populate the messages.json
files for an extension, so it doesn't need unique message ids.

[Lei Zhang, 2017-03-30 18:45:11]

lgtm

[dmazzoni, 2017-03-31 03:45:33]

https://codereview.chromium.org/2775303004/diff/1/chrome/browser/resources/ch...
File
chrome/browser/resources/chromeos/select_to_speak/strings/select_to_speak_strings.grd
(right):

https://codereview.chromium.org/2775303004/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/select_to_speak/strings/select_to_speak_strings.grd:124:
Hold down Search and click or drag to speak anything.
On 2017/03/29 22:04:42, David Tseng wrote:
> does dragging cause speech output?
> Maybe something like hold search, and select what to speak with the mouse

Good suggestion. I captured this in http://crbug.com/706976 so we
can go over all of the strings in one pass. Once we decide on a final
string I'll update it on the prefs page too.

[dmazzoni, 2017-03-31 03:45:44]

The CQ bit was checked by dmazzoni@chromium.org

[commit-bot: I haz the power, 2017-03-31 03:46:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-31 06:34:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-31 06:34:06]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Lei Zhang, 2017-03-31 06:39:21]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2017-03-31 06:39:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-31 07:48:26]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490942361880740, "parent_rev":
"dc95bcb60b6f023316870ea11aa48b2b4a96d2c7", "commit_rev":
"259d50c77c3e2b8a9a8bcc94cc8fef215aa69b27"}

[commit-bot: I haz the power, 2017-03-31 07:49:18]

Description was changed from

==========
Add i18n support to Select-to-speak

BUG=593887
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Add i18n support to Select-to-speak

BUG=593887
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2775303004
Cr-Commit-Position: refs/heads/master@{#461071}
Committed:
https://chromium.googlesource.com/chromium/src/+/259d50c77c3e2b8a9a8bcc94cc8f...
==========

[commit-bot: I haz the power, 2017-03-31 07:49:19]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/259d50c77c3e2b8a9a8bcc94cc8f...