Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Unified Diff: chrome/browser/resources/settings/a11y_page/manage_a11y_page.html

Issue 2786453002: Add links to more options pages for Chrome OS accessibility features (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/a11y_page/manage_a11y_page.html
diff --git a/chrome/browser/resources/settings/a11y_page/manage_a11y_page.html b/chrome/browser/resources/settings/a11y_page/manage_a11y_page.html
index bae3a89445623f7e086756dcc420b09334f91fb4..48f90ee92ea5d342ceed8af78f3ddc6e9c70ece3 100644
--- a/chrome/browser/resources/settings/a11y_page/manage_a11y_page.html
+++ b/chrome/browser/resources/settings/a11y_page/manage_a11y_page.html
@@ -1,5 +1,7 @@
+<link rel="import" href="chrome://resources/cr_elements/icons.html">
<link rel="import" href="chrome://resources/html/polymer.html">
<link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper-icon-button-light.html">
+<link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper-icon-button.html">
<link rel="import" href="../controls/settings_slider.html">
<link rel="import" href="../controls/settings_toggle_button.html">
<link rel="import" href="../i18n_setup.html">
@@ -39,18 +41,25 @@
<settings-toggle-button class="start"
pref="{{prefs.settings.accessibility}}"
label="$i18n{chromeVoxLabel}">
- <button class="more-actions icon-external" is="paper-icon-button-light"
+ <paper-icon-button icon="cr:settings_icon"
+ class="more-actions"
on-tap="onChromeVoxSettingsTap_"
hidden="[[!prefs.settings.accessibility.value]]"
- aria-label="$i18n{chromeVoxLabel}"></button>
+ aria-label="$i18n{chromeVoxOptionsLabel}"></paper-icon-button>
Dan Beam 2017/03/29 13:22:44 does clicking the settings icon also trigger flipp
dmazzoni 2017/03/29 15:12:50 No, because it's hidden when the toggle is off: hi
</settings-toggle-button>
</div>
<template is="dom-if" if="[[showExperimentalFeatures_]]">
- <div class="settings-box block">
+ <div class="settings-box block" actionable>
<settings-toggle-button
pref="{{prefs.settings.a11y.select_to_speak}}"
label="$i18n{selectToSpeakTitle}"
sub-label="$i18n{selectToSpeakDescription}">
+ <paper-icon-button icon="cr:settings_icon"
+ class="more-actions"
+ on-tap="onSelectToSpeakSettingsTap_"
+ hidden="[[!prefs.settings.a11y.select_to_speak.value]]"
+ aria-label="$i18n{selectToSpeakOptionsLabel}">
+ </paper-icon-button>
</settings-toggle-button>
</div>
</template>
@@ -107,13 +116,21 @@
pref="{{prefs.settings.a11y.caret_highlight}}"
label="$i18n{caretHighlightLabel}">
</settings-toggle-button>
- <template is="dom-if" if="[[showExperimentalFeatures_]]">
+ </div>
+ <template is="dom-if" if="[[showExperimentalFeatures_]]">
+ <div class="settings-box block" actionable>
<settings-toggle-button
pref="{{prefs.settings.a11y.switch_access}}"
label="$i18n{switchAccessLabel}">
+ <paper-icon-button icon="cr:settings_icon"
+ class="more-actions"
+ on-tap="onSwitchAccessSettingsTap_"
+ hidden="[[!prefs.settings.a11y.switch_access.value]]"
+ aria-label="$i18n{selectToSpeakOptionsLabel}">
+ </paper-icon-button>
</settings-toggle-button>
- </template>
- </div>
+ </div>
+ </template>
<div class="settings-box two-line" on-tap="onKeyboardTap_" actionable>
<div class="start">
$i18n{keyboardSettingsTitle}

Powered by Google App Engine
This is Rietveld 408576698