Changed CSSParserContext argument from * to & for null safety.

Changed CSSParserContext argument from * to & for null safety.

Changed the CSSParserContext argument to the parseSingleValue method in
the property APIs from a pointer to a reference to ensure that nullptr
cannot be passed.

Note that this patch changes the syntax inside parseSingleValue
implementations to get the address of CSSParserContext references to pass to 
utility methods that still expect a pointer. Future patches should change these 
utility methods to also take references instead of pointers, at which point the 
syntax inside parseSingleValue implementations can be changed back to pass the 
object.

This patch:
- changed the CSSParserContext parameter to parseSingleValue in
  CSSPropertyAPIMethods.json5 so that the generated API header files (including
  the base class header file) would update 
- changed the parameter in each of the .cpp files for the property APIs in
  core/css/properties
- updated the single call site in CSSPropertyParser.cpp
- updated the implementations of parseSingleValue in the property APIs to use
  reference syntax

Diff of generated files:
https://gist.github.com/BugsNash/1850f85afc7313dd3dac1a890299ad07/revisions

BUG=668012
Review-Url: https://codereview.chromium.org/2786153004
Cr-Commit-Position: refs/heads/master@{#462380}
Committed: https://chromium.googlesource.com/chromium/src/+/912e5f787ee415f874928b9684ea50dc75f85d40

[Bugs Nash, 2017-03-31 04:24:15]

Description was changed from

==========
Changed CSSParserContext argument from * to & for null safety.

WIP

Changed the CSSParserContext argument to the parseSingleValue method in
the property APIs from a pointer to a reference to ensure that nullptr
cannot be passed.

BUG=668012
==========

to

==========
Changed CSSParserContext argument from * to & for null safety.

WIP

Changed the CSSParserContext argument to the parseSingleValue method in
the property APIs from a pointer to a reference to ensure that nullptr
cannot be passed.

This patch:
- changed the CSSParserContext parameter to parseSingleValue in
CSSPropertyAPIMethods.json5 so that the generated API header files (including
the base class header file) would update 
- changed the argument in each of the .cpp files for the property APIs in
core/css/properties
- updated the call site in CSSPropertyParser.cpp
- updated the implementations of parseSingleValue in the property APIs to use
reference syntax (TODO)

BUG=668012
==========

[Bugs Nash, 2017-03-31 04:24:15]

bugsnash@chromium.org changed reviewers:
+ shend@chromium.org

[shend, 2017-03-31 04:31:17]

Yesss! Love this patch. In addition to safety, it's also self documenting.
Previously, someone looking at the interface wouldn't know if passing in null is
okay or not. This interface is much clearer. lgtm with nits.

https://codereview.chromium.org/2786153004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp (right):

https://codereview.chromium.org/2786153004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:1840: return
cssPropertyDesc.parseSingleValue(m_range, *m_context);
In these places, I would put a DCHECK for null (unless there was a DCHECK before
this).

[Bugs Nash, 2017-03-31 04:36:02]

On 2017/03/31 at 04:31:17, shend wrote:
> Yesss! Love this patch. In addition to safety, it's also self documenting.
Previously, someone looking at the interface wouldn't know if passing in null is
okay or not. This interface is much clearer. lgtm with nits.
> 
>
https://codereview.chromium.org/2786153004/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp (right):
> 
>
https://codereview.chromium.org/2786153004/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:1840: return
cssPropertyDesc.parseSingleValue(m_range, *m_context);
> In these places, I would put a DCHECK for null (unless there was a DCHECK
before this).

Done!

[Bugs Nash, 2017-03-31 04:36:38]

Description was changed from

==========
Changed CSSParserContext argument from * to & for null safety.

WIP

Changed the CSSParserContext argument to the parseSingleValue method in
the property APIs from a pointer to a reference to ensure that nullptr
cannot be passed.

This patch:
- changed the CSSParserContext parameter to parseSingleValue in
CSSPropertyAPIMethods.json5 so that the generated API header files (including
the base class header file) would update 
- changed the argument in each of the .cpp files for the property APIs in
core/css/properties
- updated the call site in CSSPropertyParser.cpp
- updated the implementations of parseSingleValue in the property APIs to use
reference syntax (TODO)

BUG=668012
==========

to

==========
Changed CSSParserContext argument from * to & for null safety.

WIP

Changed the CSSParserContext argument to the parseSingleValue method in
the property APIs from a pointer to a reference to ensure that nullptr
cannot be passed.

This patch:
- changed the CSSParserContext parameter to parseSingleValue in
CSSPropertyAPIMethods.json5 so that the generated API header files (including
the base class header file) would update 
- changed the argument in each of the .cpp files for the property APIs in
core/css/properties
- updated the call site in CSSPropertyParser.cpp
- updated the implementations of parseSingleValue in the property APIs to use
reference syntax (TODO)

Diff of generated files (TODO)

BUG=668012
==========

[Bugs Nash, 2017-04-04 01:13:09]

Description was changed from

==========
Changed CSSParserContext argument from * to & for null safety.

WIP

Changed the CSSParserContext argument to the parseSingleValue method in
the property APIs from a pointer to a reference to ensure that nullptr
cannot be passed.

This patch:
- changed the CSSParserContext parameter to parseSingleValue in
CSSPropertyAPIMethods.json5 so that the generated API header files (including
the base class header file) would update 
- changed the argument in each of the .cpp files for the property APIs in
core/css/properties
- updated the call site in CSSPropertyParser.cpp
- updated the implementations of parseSingleValue in the property APIs to use
reference syntax (TODO)

Diff of generated files (TODO)

BUG=668012
==========

to

==========
Changed CSSParserContext argument from * to & for null safety.

Changed the CSSParserContext argument to the parseSingleValue method in
the property APIs from a pointer to a reference to ensure that nullptr
cannot be passed.

Note that this patch changes the syntax inside parseSingleValue
implementations to get the address of CSSParserContext references to pass to 
utility methods that still expect a pointer. Future patches should change these 
utility methods to also take references instead of pointers, at which point the 
syntax inside parseSingleValue implementations can be changed back to pass the 
object.

This patch:
- changed the CSSParserContext parameter to parseSingleValue in
  CSSPropertyAPIMethods.json5 so that the generated API header files (including
  the base class header file) would update 
- changed the parameter in each of the .cpp files for the property APIs in
  core/css/properties
- updated the single call site in CSSPropertyParser.cpp
- updated the implementations of parseSingleValue in the property APIs to use
  reference syntax

Diff of generated files:
https://gist.github.com/BugsNash/1850f85afc7313dd3dac1a890299ad07/revisions

BUG=668012
==========

[Bugs Nash, 2017-04-04 01:13:37]

Darren you might want to have another look at this as some stuff has changed.
Thanks!

[shend, 2017-04-04 01:27:53]

still lgtm

[Bugs Nash, 2017-04-04 01:30:08]

bugsnash@chromium.org changed reviewers:
+ meade@chromium.org

[Bugs Nash, 2017-04-04 01:30:15]

On 2017/04/04 at 01:27:53, shend wrote:
> still lgtm

+meade@ for owners

[Bugs Nash, 2017-04-04 01:30:15]

On 2017/04/04 at 01:27:53, shend wrote:
> still lgtm

+meade@ for owners

[meade_UTC10, 2017-04-06 03:06:27]

lgtm

https://codereview.chromium.org/2786153004/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/properties/CSSPropertyAPIAlignItems.cpp
(right):

https://codereview.chromium.org/2786153004/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/properties/CSSPropertyAPIAlignItems.cpp:15:
const CSSParserContext& context) {
nit: if context isn't used, it can be omitted (maybe another boring cleanup CL?)

[Bugs Nash, 2017-04-06 05:10:16]

The CQ bit was checked by bugsnash@chromium.org

[commit-bot: I haz the power, 2017-04-06 05:10:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 07:04:44]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1491455416619640,
"parent_rev": "16f5c5b2155faa46890e2c5ad18bd27f7c506deb", "commit_rev":
"912e5f787ee415f874928b9684ea50dc75f85d40"}

[commit-bot: I haz the power, 2017-04-06 07:05:40]

Description was changed from

==========
Changed CSSParserContext argument from * to & for null safety.

Changed the CSSParserContext argument to the parseSingleValue method in
the property APIs from a pointer to a reference to ensure that nullptr
cannot be passed.

Note that this patch changes the syntax inside parseSingleValue
implementations to get the address of CSSParserContext references to pass to 
utility methods that still expect a pointer. Future patches should change these 
utility methods to also take references instead of pointers, at which point the 
syntax inside parseSingleValue implementations can be changed back to pass the 
object.

This patch:
- changed the CSSParserContext parameter to parseSingleValue in
  CSSPropertyAPIMethods.json5 so that the generated API header files (including
  the base class header file) would update 
- changed the parameter in each of the .cpp files for the property APIs in
  core/css/properties
- updated the single call site in CSSPropertyParser.cpp
- updated the implementations of parseSingleValue in the property APIs to use
  reference syntax

Diff of generated files:
https://gist.github.com/BugsNash/1850f85afc7313dd3dac1a890299ad07/revisions

BUG=668012
==========

to

==========
Changed CSSParserContext argument from * to & for null safety.

Changed the CSSParserContext argument to the parseSingleValue method in
the property APIs from a pointer to a reference to ensure that nullptr
cannot be passed.

Note that this patch changes the syntax inside parseSingleValue
implementations to get the address of CSSParserContext references to pass to 
utility methods that still expect a pointer. Future patches should change these 
utility methods to also take references instead of pointers, at which point the 
syntax inside parseSingleValue implementations can be changed back to pass the 
object.

This patch:
- changed the CSSParserContext parameter to parseSingleValue in
  CSSPropertyAPIMethods.json5 so that the generated API header files (including
  the base class header file) would update 
- changed the parameter in each of the .cpp files for the property APIs in
  core/css/properties
- updated the single call site in CSSPropertyParser.cpp
- updated the implementations of parseSingleValue in the property APIs to use
  reference syntax

Diff of generated files:
https://gist.github.com/BugsNash/1850f85afc7313dd3dac1a890299ad07/revisions

BUG=668012

Review-Url: https://codereview.chromium.org/2786153004
Cr-Commit-Position: refs/heads/master@{#462380}
Committed:
https://chromium.googlesource.com/chromium/src/+/912e5f787ee415f874928b9684ea...
==========

[commit-bot: I haz the power, 2017-04-06 07:05:41]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/912e5f787ee415f874928b9684ea...

[findit-for-me, 2017-04-06 07:21:59]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2801893003/ by
findit-for-me@appspot.gserviceaccount.com.

The reason for reverting is: 
Findit identified CL at revision 462380 as the culprit for
failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb....

[Michael Achenbach, 2017-04-06 07:30:35]

On 2017/04/06 07:21:59, findit-for-me wrote:
> A revert of this CL (patchset #4 id:60001) has been created in
> https://codereview.chromium.org/2801893003/ by
> mailto:findit-for-me@appspot.gserviceaccount.com.
> 
> The reason for reverting is: 
> Findit identified CL at revision 462380 as the culprit for
> failures in the build cycles as shown on:
>
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb....

Guess this CL should have depended on https://codereview.chromium.org/2783543002
See:
https://commondatastorage.googleapis.com/chrome-infra-docs/flat/depot_tools/d...

[awdf, 2017-04-06 08:02:34]

On 2017/04/06 07:30:35, Michael Achenbach wrote:
> On 2017/04/06 07:21:59, findit-for-me wrote:
> > A revert of this CL (patchset #4 id:60001) has been created in
> > https://codereview.chromium.org/2801893003/ by
> > mailto:findit-for-me@appspot.gserviceaccount.com.
> > 
> > The reason for reverting is: 
> > Findit identified CL at revision 462380 as the culprit for
> > failures in the build cycles as shown on:
> >
>
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb....
> 
> Guess this CL should have depended on
https://codereview.chromium.org/2783543002
> See:
>
https://commondatastorage.googleapis.com/chrome-infra-docs/flat/depot_tools/d...

I created https://bugs.chromium.org/p/chromium/issues/detail?id=708924 for the
compile failures.
I reverted https://codereview.chromium.org/2783543002 just after this was
reverted (I didn't see this one in the blamelist)

I guess they just need to be relanded in the right order once things are back to
green.