third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp - Issue 2786153004: Changed CSSParserContext argument from * to & for null safety.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp

Issue 2786153004: Changed CSSParserContext argument from * to & for null safety. (Closed)

Patch Set: Updated syntax where ref is passed as pointer Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp

diff --git a/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp b/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp

index fc9cd344d825c5cbdb9e86fe2b5d34352f04abd6..6c69b7b8f9aaae883549777b95066489caec9323 100644

--- a/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp

+++ b/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp

@@ -1836,8 +1836,10 @@ const CSSValue* CSSPropertyParser::parseSingleValue(

// statement.

const CSSPropertyDescriptor& cssPropertyDesc =

CSSPropertyDescriptor::get(property);

- if (cssPropertyDesc.parseSingleValue)

- return cssPropertyDesc.parseSingleValue(m_range, m_context);

+ if (cssPropertyDesc.parseSingleValue) {

+ DCHECK(m_context);

+ return cssPropertyDesc.parseSingleValue(m_range, *m_context);

+ }

switch (property) {

case CSSPropertyFontFeatureSettings: