third_party/WebKit/Source/core/css/properties/CSSPropertyAPIAlignItems.cpp - Issue 2786153004: Changed CSSParserContext argument from * to & for null safety.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/properties/CSSPropertyAPIAlignItems.cpp

Issue 2786153004: Changed CSSParserContext argument from * to & for null safety. (Closed)

Patch Set: Updated syntax where ref is passed as pointer Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp ('k') | third_party/WebKit/Source/core/css/properties/CSSPropertyAPIAlignOrJustifyContent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/properties/CSSPropertyAPIAlignItems.cpp

diff --git a/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIAlignItems.cpp b/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIAlignItems.cpp

index c8a956acc890640547583561446e0b975a57b73e..790c98d63f887e70690893f9c20c4f83cefa147d 100644

--- a/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIAlignItems.cpp

+++ b/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIAlignItems.cpp

@@ -12,7 +12,7 @@ namespace blink {

const CSSValue* CSSPropertyAPIAlignItems::parseSingleValue(

CSSParserTokenRange& range,

- const CSSParserContext* context) {

+ const CSSParserContext& context) {

meade_UTC10 2017/04/06 03:06:27 nit: if context isn't used, it can be omitted (may

DCHECK(RuntimeEnabledFeatures::cssGridLayoutEnabled());

// align-items property does not allow the 'auto' value.

if (CSSPropertyParserHelpers::identMatches<CSSValueAuto>(range.peek().id()))