[turbofan] introduce Int32/64AbsWithOverflow optional operator

[turbofan] introduce Int32/64AbsWithOverflow optional operator

some arch like s390 has native instr can benefit from this.
see ~10% improvement on MathAbs on s390

Review-Url: https://codereview.chromium.org/2785773002
Cr-Commit-Position: refs/heads/master@{#44310}
Committed: https://chromium.googlesource.com/v8/v8/+/ab5a0e2fed25e8215d160c25962141dd41fcafca

[john.yan, 2017-03-29 17:50:49]

The CQ bit was checked by jyan@ca.ibm.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 17:50:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[john.yan, 2017-03-29 17:53:24]

Description was changed from

==========
[turbofan] introduce Int32/64AbsWithOverflow optional operator

some arch like s390 has native instr can benefit from this.
==========

to

==========
[turbofan] introduce Int32/64AbsWithOverflow optional operator

some arch like s390 has native instr can benefit from this.
==========

[john.yan, 2017-03-29 17:53:25]

jyan@ca.ibm.com changed reviewers:
+ bjaideep@ca.ibm.com, bmeurer@chromium.org, joransiu@ca.ibm.com,
michael_dawson@ca.ibm.com, mtrofin@chromium.org

[commit-bot: I haz the power, 2017-03-29 18:14:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 18:14:56]

Dry run: This issue passed the CQ dry run.

[john.yan, 2017-03-29 18:56:17]

Description was changed from

==========
[turbofan] introduce Int32/64AbsWithOverflow optional operator

some arch like s390 has native instr can benefit from this.
==========

to

==========
[turbofan] introduce Int32/64AbsWithOverflow optional operator

some arch like s390 has native instr can benefit from this.
see ~10% improvement on MathAbs on s390
==========

[john.yan, 2017-03-29 18:56:28]

ptal

[Benedikt Meurer, 2017-03-31 04:33:08]

https://codereview.chromium.org/2785773002/diff/1/src/compiler/s390/instructi...
File src/compiler/s390/instruction-selector-s390.cc (right):

https://codereview.chromium.org/2785773002/diff/1/src/compiler/s390/instructi...
src/compiler/s390/instruction-selector-s390.cc:1251: UNREACHABLE();
Can you also provide a baseline implementation of this.

https://codereview.chromium.org/2785773002/diff/1/src/compiler/s390/instructi...
src/compiler/s390/instruction-selector-s390.cc:1255: UNREACHABLE();
Same here.

[john.yan, 2017-03-31 05:43:55]

On 2017/03/31 04:33:08, Benedikt Meurer wrote:
>
https://codereview.chromium.org/2785773002/diff/1/src/compiler/s390/instructi...
> File src/compiler/s390/instruction-selector-s390.cc (right):
> 
>
https://codereview.chromium.org/2785773002/diff/1/src/compiler/s390/instructi...
> src/compiler/s390/instruction-selector-s390.cc:1251: UNREACHABLE();
> Can you also provide a baseline implementation of this.
> 
>
https://codereview.chromium.org/2785773002/diff/1/src/compiler/s390/instructi...
> src/compiler/s390/instruction-selector-s390.cc:1255: UNREACHABLE();
> Same here.

Done, thanks.

[john.yan, 2017-03-31 05:44:01]

The CQ bit was checked by jyan@ca.ibm.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-31 05:44:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-31 06:09:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-31 06:09:47]

Dry run: This issue passed the CQ dry run.

[Benedikt Meurer, 2017-03-31 06:20:23]

lgtm

[john.yan, 2017-03-31 14:10:00]

The CQ bit was unchecked by jyan@ca.ibm.com

[john.yan, 2017-03-31 14:10:02]

The CQ bit was checked by jyan@ca.ibm.com

[commit-bot: I haz the power, 2017-03-31 14:10:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[john.yan, 2017-03-31 14:10:45]

On 2017/03/31 06:20:23, Benedikt Meurer wrote:
> lgtm

thanks!

[commit-bot: I haz the power, 2017-03-31 14:12:47]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490969402278690,
"parent_rev": "591562c131ee58d9f72c9a2b1884861566af65b1", "commit_rev":
"ab5a0e2fed25e8215d160c25962141dd41fcafca"}

[commit-bot: I haz the power, 2017-03-31 14:12:52]

Description was changed from

==========
[turbofan] introduce Int32/64AbsWithOverflow optional operator

some arch like s390 has native instr can benefit from this.
see ~10% improvement on MathAbs on s390
==========

to

==========
[turbofan] introduce Int32/64AbsWithOverflow optional operator

some arch like s390 has native instr can benefit from this.
see ~10% improvement on MathAbs on s390

Review-Url: https://codereview.chromium.org/2785773002
Cr-Commit-Position: refs/heads/master@{#44310}
Committed:
https://chromium.googlesource.com/v8/v8/+/ab5a0e2fed25e8215d160c25962141dd41f...
==========

[commit-bot: I haz the power, 2017-03-31 14:12:53]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/ab5a0e2fed25e8215d160c25962141dd41f...