Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issue 2785593002: Revert of Delete "Google Profile photo" for the Active Directory (patchset #2 id:20001 of https://c… (Closed)

Created:
3 years, 8 months ago by Alexander Alekseev
Modified:
3 years, 8 months ago
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Revert of Delete "Google Profile photo" for the Active Directory (patchset #2 id:20001 of https://codereview.chromium.org/2666893002/ ) Reason for revert: First, this has a race: CONTEXT_KEY_HAS_GAIA_ACCOUNT can (and actually does) come after CONTEXT_KEY_PROFILE_PICTURE_DATA_URL thus triggering exception: login.js:1208 Uncaught TypeError: Cannot read property 'title' of undefined at HTMLUnknownElement.updateItem (login.js:1208) at Array.<anonymous> (login.js:9504) at ScreenContext.applyChanges (login.js:538) at HTMLDivElement.contextChanged_ (login.js:329) at Object.api.contextChanged (login.js:424) at <anonymous>:1:23 Second, it breaks supervised user creation screen (and probably other screens that share user-image-grid object). BUG=697842, 682236 Original issue's description: > Delete "Google Profile photo" for the Active Directory > > Delete "Google Profile photo" choice from the image choice screen for > the Active Directory users. > > BUG=682236 > TEST=manual > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation > > Review-Url: https://codereview.chromium.org/2666893002 > Cr-Commit-Position: refs/heads/master@{#447513} > Committed: https://chromium.googlesource.com/chromium/src/+/33f901b2ff76e1d08d80e3ba5d1d079178cb4978 TBR=achuith@chromium.org,rsorokin@chromium.org BUG=682236 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2727953004 Cr-Commit-Position: refs/heads/master@{#454525} (cherry picked from commit ed71ca7437db67890fdc2848ff4edea9aa2b0cca) Review-Url: https://codereview.chromium.org/2785593002 . Cr-Commit-Position: refs/branch-heads/3029@{#466} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/716621dd4c92357b9b93ae44603fbe53204e5bfd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -35 lines) Patch
M chrome/browser/chromeos/login/screens/user_image_screen.cc View 2 chunks +2 lines, -9 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_screen_user_image.js View 3 chunks +20 lines, -26 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Alexander Alekseev
3 years, 8 months ago (2017-03-29 01:03:44 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
716621dd4c92357b9b93ae44603fbe53204e5bfd.

Powered by Google App Engine
This is Rietveld 408576698