DescriptionRevert of Delete "Google Profile photo" for the Active Directory (patchset #2 id:20001 of https://codereview.chromium.org/2666893002/ )
Reason for revert:
First, this has a race: CONTEXT_KEY_HAS_GAIA_ACCOUNT can (and actually does) come after CONTEXT_KEY_PROFILE_PICTURE_DATA_URL thus triggering exception:
login.js:1208 Uncaught TypeError: Cannot read property 'title' of undefined
at HTMLUnknownElement.updateItem (login.js:1208)
at Array.<anonymous> (login.js:9504)
at ScreenContext.applyChanges (login.js:538)
at HTMLDivElement.contextChanged_ (login.js:329)
at Object.api.contextChanged (login.js:424)
at <anonymous>:1:23
Second, it breaks supervised user creation screen (and probably other screens that share user-image-grid object).
BUG=697842, 682236
Original issue's description:
> Delete "Google Profile photo" for the Active Directory
>
> Delete "Google Profile photo" choice from the image choice screen for
> the Active Directory users.
>
> BUG=682236
> TEST=manual
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
>
> Review-Url: https://codereview.chromium.org/2666893002
> Cr-Commit-Position: refs/heads/master@{#447513}
> Committed: https://chromium.googlesource.com/chromium/src/+/33f901b2ff76e1d08d80e3ba5d1d079178cb4978
TBR=achuith@chromium.org,rsorokin@chromium.org
BUG=682236
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2727953004
Cr-Commit-Position: refs/heads/master@{#454525}
(cherry picked from commit ed71ca7437db67890fdc2848ff4edea9aa2b0cca)
Review-Url: https://codereview.chromium.org/2785593002 .
Cr-Commit-Position: refs/branch-heads/3029@{#466}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Committed: https://chromium.googlesource.com/chromium/src/+/716621dd4c92357b9b93ae44603fbe53204e5bfd
Patch Set 1 #
Messages
Total messages: 2 (1 generated)
|