Delete "Google Profile photo" for the Active Directory

Delete "Google Profile photo" for the Active Directory

Delete "Google Profile photo" choice from the image choice screen for
the Active Directory users.

BUG=682236
TEST=manual
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2666893002
Cr-Commit-Position: refs/heads/master@{#447513}
Committed: https://chromium.googlesource.com/chromium/src/+/33f901b2ff76e1d08d80e3ba5d1d079178cb4978

[Roman Sorokin (ftl), 2017-01-31 10:26:25]

Description was changed from

==========
Delete "Google Profile photo" for the Active Directory

Delete "Google Profile photo" choice from the image choice screen for
the Active Directory users.

BUG=682236
TEST=manual
==========

to

==========
Delete "Google Profile photo" for the Active Directory

Delete "Google Profile photo" choice from the image choice screen for
the Active Directory users.

BUG=682236
TEST=manual
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Roman Sorokin (ftl), 2017-01-31 10:27:08]

The CQ bit was checked by rsorokin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-31 10:27:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Roman Sorokin (ftl), 2017-01-31 10:28:12]

rsorokin@chromium.org changed reviewers:
+ achuith@chromium.org

[Roman Sorokin (ftl), 2017-01-31 10:28:13]

Hey Achuith, could you PTAL? Thanks!

[commit-bot: I haz the power, 2017-01-31 12:06:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-31 12:06:37]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[achuithb, 2017-01-31 20:33:05]

lgtm

https://codereview.chromium.org/2666893002/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/screens/user_image_screen.cc (right):

https://codereview.chromium.org/2666893002/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/screens/user_image_screen.cc:283: const
user_manager::User* user = GetUser();
Maybe add a comment like:
// Fetch profile image for GAIA accounts.

[Roman Sorokin (ftl), 2017-02-01 13:15:56]

https://codereview.chromium.org/2666893002/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/screens/user_image_screen.cc (right):

https://codereview.chromium.org/2666893002/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/screens/user_image_screen.cc:283: const
user_manager::User* user = GetUser();
On 2017/01/31 20:33:05, achuithb wrote:
> Maybe add a comment like:
> // Fetch profile image for GAIA accounts.

Done.

[Roman Sorokin (ftl), 2017-02-01 13:16:02]

The CQ bit was checked by rsorokin@chromium.org

[Roman Sorokin (ftl), 2017-02-01 13:16:02]

The patchset sent to the CQ was uploaded after l-g-t-m from achuith@chromium.org
Link to the patchset: https://codereview.chromium.org/2666893002/#ps20001
(title: "Comment")

[commit-bot: I haz the power, 2017-02-01 13:16:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-01 15:12:46]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485954962245310,
"parent_rev": "f3359876535eb294692b53ad472d52bb7d6abdd7", "commit_rev":
"33f901b2ff76e1d08d80e3ba5d1d079178cb4978"}

[commit-bot: I haz the power, 2017-02-01 15:13:23]

Description was changed from

==========
Delete "Google Profile photo" for the Active Directory

Delete "Google Profile photo" choice from the image choice screen for
the Active Directory users.

BUG=682236
TEST=manual
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Delete "Google Profile photo" for the Active Directory

Delete "Google Profile photo" choice from the image choice screen for
the Active Directory users.

BUG=682236
TEST=manual
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2666893002
Cr-Commit-Position: refs/heads/master@{#447513}
Committed:
https://chromium.googlesource.com/chromium/src/+/33f901b2ff76e1d08d80e3ba5d1d...
==========

[commit-bot: I haz the power, 2017-02-01 15:13:26]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/33f901b2ff76e1d08d80e3ba5d1d...

[Alexander Alekseev, 2017-03-03 04:53:40]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2727953004/ by alemate@chromium.org.

The reason for reverting is: First, this has a race:
CONTEXT_KEY_HAS_GAIA_ACCOUNT can (and actually does) come after
CONTEXT_KEY_PROFILE_PICTURE_DATA_URL thus triggering exception:

login.js:1208 Uncaught TypeError: Cannot read property 'title' of undefined
    at HTMLUnknownElement.updateItem (login.js:1208)
    at Array.<anonymous> (login.js:9504)
    at ScreenContext.applyChanges (login.js:538)
    at HTMLDivElement.contextChanged_ (login.js:329)
    at Object.api.contextChanged (login.js:424)
    at <anonymous>:1:23

Second, it breaks supervised user creation screen (and probably other screens
that share user-image-grid object).

BUG=697842,682236.