Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2727953004: Revert of Delete "Google Profile photo" for the Active Directory (Closed)

Created:
3 years, 9 months ago by Alexander Alekseev
Modified:
3 years, 9 months ago
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Delete "Google Profile photo" for the Active Directory (patchset #2 id:20001 of https://codereview.chromium.org/2666893002/ ) Reason for revert: First, this has a race: CONTEXT_KEY_HAS_GAIA_ACCOUNT can (and actually does) come after CONTEXT_KEY_PROFILE_PICTURE_DATA_URL thus triggering exception: login.js:1208 Uncaught TypeError: Cannot read property 'title' of undefined at HTMLUnknownElement.updateItem (login.js:1208) at Array.<anonymous> (login.js:9504) at ScreenContext.applyChanges (login.js:538) at HTMLDivElement.contextChanged_ (login.js:329) at Object.api.contextChanged (login.js:424) at <anonymous>:1:23 Second, it breaks supervised user creation screen (and probably other screens that share user-image-grid object). BUG=697842, 682236 Original issue's description: > Delete "Google Profile photo" for the Active Directory > > Delete "Google Profile photo" choice from the image choice screen for > the Active Directory users. > > BUG=682236 > TEST=manual > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation > > Review-Url: https://codereview.chromium.org/2666893002 > Cr-Commit-Position: refs/heads/master@{#447513} > Committed: https://chromium.googlesource.com/chromium/src/+/33f901b2ff76e1d08d80e3ba5d1d079178cb4978 TBR=achuith@chromium.org,rsorokin@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=682236 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2727953004 Cr-Commit-Position: refs/heads/master@{#454525} Committed: https://chromium.googlesource.com/chromium/src/+/ed71ca7437db67890fdc2848ff4edea9aa2b0cca

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -35 lines) Patch
M chrome/browser/chromeos/login/screens/user_image_screen.cc View 1 2 chunks +2 lines, -9 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_screen_user_image.js View 1 3 chunks +20 lines, -26 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Alexander Alekseev
Created Revert of Delete "Google Profile photo" for the Active Directory
3 years, 9 months ago (2017-03-03 04:53:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2727953004/1
3 years, 9 months ago (2017-03-03 04:53:56 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xcode-clang/builds/53232)
3 years, 9 months ago (2017-03-03 04:55:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2727953004/120001
3 years, 9 months ago (2017-03-03 05:04:13 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-03 06:05:39 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/ed71ca7437db67890fdc2848ff4e...

Powered by Google App Engine
This is Rietveld 408576698