Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 278523004: Blink GC plugin: require that trace call base::trace and traceAfterDispatch call base::traceAfterDi… (Closed)

Created:
6 years, 7 months ago by zerny-chromium
Modified:
6 years, 7 months ago
Reviewers:
wibling-chromium
CC:
chromium-reviews, oilpan-reviews
Visibility:
Public.

Description

Blink GC plugin: require that trace call base::trace and traceAfterDispatch call base::traceAfterDispatch. BUG=334149 R=wibling@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270057

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -12 lines) Patch
M tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp View 1 1 chunk +7 lines, -4 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/finalize_after_dispatch.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/trace_after_dispatch.cpp View 1 chunk +5 lines, -3 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/trace_after_dispatch.txt View 1 chunk +1 line, -1 line 0 comments Download
M tools/clang/blink_gc_plugin/tests/virtual_and_trace_after_dispatch.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
zerny-chromium
6 years, 7 months ago (2014-05-08 11:19:36 UTC) #1
wibling-chromium
lgtm
6 years, 7 months ago (2014-05-08 11:34:27 UTC) #2
zerny-chromium
The CQ bit was checked by zerny@chromium.org
6 years, 7 months ago (2014-05-13 09:13:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zerny@chromium.org/278523004/10001
6 years, 7 months ago (2014-05-13 09:14:16 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-13 09:15:21 UTC) #5
Message was sent while issue was closed.
Change committed as 270057

Powered by Google App Engine
This is Rietveld 408576698