tools/clang/blink_gc_plugin/tests/virtual_and_trace_after_dispatch.cpp - Issue 278523004: Blink GC plugin: require that trace call base::trace and traceAfterDispatch call base::traceAfterDi…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/blink_gc_plugin/tests/virtual_and_trace_after_dispatch.cpp

Issue 278523004: Blink GC plugin: require that trace call base::trace and traceAfterDispatch call base::traceAfterDi… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/clang/blink_gc_plugin/tests/virtual_and_trace_after_dispatch.cpp

diff --git a/tools/clang/blink_gc_plugin/tests/virtual_and_trace_after_dispatch.cpp b/tools/clang/blink_gc_plugin/tests/virtual_and_trace_after_dispatch.cpp

index 1ed9c2f94f338eb5ebb99a08144bfb348a81bcb2..9cd255ec4fcb61bc8c08508d6f8858cfad7d0e12 100644

--- a/tools/clang/blink_gc_plugin/tests/virtual_and_trace_after_dispatch.cpp

+++ b/tools/clang/blink_gc_plugin/tests/virtual_and_trace_after_dispatch.cpp

@@ -24,7 +24,7 @@ void A::traceAfterDispatch(Visitor* visitor)

void B::traceAfterDispatch(Visitor* visitor)

{

visitor->trace(m_a);

- A::trace(visitor);

+ A::traceAfterDispatch(visitor);

}

« no previous file with comments | « tools/clang/blink_gc_plugin/tests/trace_after_dispatch.txt ('k') | no next file » | no next file with comments »