tools/clang/blink_gc_plugin/tests/trace_after_dispatch.cpp - Issue 278523004: Blink GC plugin: require that trace call base::trace and traceAfterDispatch call base::traceAfterDi…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/blink_gc_plugin/tests/trace_after_dispatch.cpp

Issue 278523004: Blink GC plugin: require that trace call base::trace and traceAfterDispatch call base::traceAfterDi… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/clang/blink_gc_plugin/tests/finalize_after_dispatch.cpp ('k') | tools/clang/blink_gc_plugin/tests/trace_after_dispatch.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/clang/blink_gc_plugin/tests/trace_after_dispatch.cpp

diff --git a/tools/clang/blink_gc_plugin/tests/trace_after_dispatch.cpp b/tools/clang/blink_gc_plugin/tests/trace_after_dispatch.cpp

index be41a60b15132c0e79cceda037573a8612dfced1..aa51ea421bedfe2226dadb31d163ffc6a05e6a6f 100644

--- a/tools/clang/blink_gc_plugin/tests/trace_after_dispatch.cpp

+++ b/tools/clang/blink_gc_plugin/tests/trace_after_dispatch.cpp

@@ -30,19 +30,21 @@ void A::traceAfterDispatch(Visitor* visitor)

void B::traceAfterDispatch(Visitor* visitor)

{

visitor->trace(m_a);

- // Missing A::trace(visitor);

+ // Missing A::traceAfterDispatch(visitor);

+ // Also check that calling trace does not count.

+ A::trace(visitor);

}

void C::traceAfterDispatch(Visitor* visitor)

{

// Missing visitor->trace(m_a);

- A::trace(visitor);

+ A::traceAfterDispatch(visitor);

}

void D::traceAfterDispatch(Visitor* visitor)

{

visitor->trace(m_a);

- Abstract::trace(visitor);

+ Abstract::traceAfterDispatch(visitor);

}