tools/clang/blink_gc_plugin/tests/trace_after_dispatch.txt - Issue 278523004: Blink GC plugin: require that trace call base::trace and traceAfterDispatch call base::traceAfterDi…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/blink_gc_plugin/tests/trace_after_dispatch.txt

Issue 278523004: Blink GC plugin: require that trace call base::trace and traceAfterDispatch call base::traceAfterDi… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/clang/blink_gc_plugin/tests/trace_after_dispatch.cpp ('k') | tools/clang/blink_gc_plugin/tests/virtual_and_trace_after_dispatch.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/clang/blink_gc_plugin/tests/trace_after_dispatch.txt

diff --git a/tools/clang/blink_gc_plugin/tests/trace_after_dispatch.txt b/tools/clang/blink_gc_plugin/tests/trace_after_dispatch.txt

index e076e3424da3e6c0729dacc46db7bc05ce40dc8a..877fbbe6fdd166855ea3d5ad9e639456c1ab3cdb 100644

--- a/tools/clang/blink_gc_plugin/tests/trace_after_dispatch.txt

+++ b/tools/clang/blink_gc_plugin/tests/trace_after_dispatch.txt

@@ -4,7 +4,7 @@ void A::trace(Visitor* visitor)

trace_after_dispatch.cpp:30:1: warning: [blink-gc] Base class 'A' of derived class 'B' requires tracing.

void B::traceAfterDispatch(Visitor* visitor)

-trace_after_dispatch.cpp:36:1: warning: [blink-gc] Class 'C' has untraced fields that require tracing.

+trace_after_dispatch.cpp:38:1: warning: [blink-gc] Class 'C' has untraced fields that require tracing.

void C::traceAfterDispatch(Visitor* visitor)

./trace_after_dispatch.h:36:5: note: [blink-gc] Untraced field 'm_a' declared here: