Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 2785183002: Remove histograms NewTabPage.IconsReal/IconsColor/IconsGray (Closed)

Created:
3 years, 8 months ago by Marc Treib
Modified:
3 years, 8 months ago
Reviewers:
mastiz, Ilya Sherman
CC:
chromium-reviews, noyau+watch_chromium.org, asvitkine+watch_chromium.org, ntp-dev+reviews_chromium.org, Steven Holte
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove histograms NewTabPage.IconsReal/IconsColor/IconsGray They have been replaced by NewTabPage.TileType and NewTabPage.SuggestionsImpression.IconsReal/IconsColor/IconsGray. BUG=703165 Review-Url: https://codereview.chromium.org/2785183002 Cr-Commit-Position: refs/heads/master@{#461645} Committed: https://chromium.googlesource.com/chromium/src/+/35508f05e62ec481dfa71cde31cb1c9aa5492b17

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -26 lines) Patch
M components/ntp_tiles/metrics.cc View 3 chunks +0 lines, -14 lines 0 comments Download
M components/ntp_tiles/metrics_unittest.cc View 2 chunks +0 lines, -12 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 3 chunks +12 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 23 (15 generated)
Marc Treib
PTAL!
3 years, 8 months ago (2017-03-30 14:52:20 UTC) #3
Marc Treib
+holte for histograms.xml, PTAL!
3 years, 8 months ago (2017-03-31 07:11:15 UTC) #13
mastiz
LGTM, thanks!
3 years, 8 months ago (2017-03-31 07:14:06 UTC) #14
Marc Treib
Ping holte@ - please look at histograms.xml. Thanks!
3 years, 8 months ago (2017-04-03 09:33:11 UTC) #15
Marc Treib
+isherman since holte is OOO. PTAL at histograms.xml, thanks!
3 years, 8 months ago (2017-04-03 14:58:06 UTC) #17
Ilya Sherman
histograms.xml lgtm, thanks.
3 years, 8 months ago (2017-04-03 21:35:40 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2785183002/1
3 years, 8 months ago (2017-04-04 05:38:23 UTC) #20
commit-bot: I haz the power
3 years, 8 months ago (2017-04-04 06:41:48 UTC) #23
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/35508f05e62ec481dfa71cde31cb...

Powered by Google App Engine
This is Rietveld 408576698