Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Unified Diff: components/ntp_tiles/metrics_unittest.cc

Issue 2785183002: Remove histograms NewTabPage.IconsReal/IconsColor/IconsGray (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/ntp_tiles/metrics.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/ntp_tiles/metrics_unittest.cc
diff --git a/components/ntp_tiles/metrics_unittest.cc b/components/ntp_tiles/metrics_unittest.cc
index acb8c5a0ef29409958f283c2b3e394dc67fc92b8..a5ed2c2ca740d90ad1df195fa5d657181fb73b4b 100644
--- a/components/ntp_tiles/metrics_unittest.cc
+++ b/components/ntp_tiles/metrics_unittest.cc
@@ -72,12 +72,6 @@ TEST(RecordPageImpressionTest, ShouldRecordUmaForIcons) {
base::Bucket(/*min=*/ICON_COLOR, /*count=*/2)));
EXPECT_THAT(histogram_tester.GetAllSamples("NewTabPage.TileType.popular"),
ElementsAre(base::Bucket(/*min=*/ICON_COLOR, /*count=*/1)));
- EXPECT_THAT(histogram_tester.GetAllSamples("NewTabPage.IconsReal"),
- ElementsAre(base::Bucket(/*min=*/4, /*count=*/1)));
- EXPECT_THAT(histogram_tester.GetAllSamples("NewTabPage.IconsColor"),
- ElementsAre(base::Bucket(/*min=*/3, /*count=*/1)));
- EXPECT_THAT(histogram_tester.GetAllSamples("NewTabPage.IconsGray"),
- ElementsAre(base::Bucket(/*min=*/1, /*count=*/1)));
EXPECT_THAT(histogram_tester.GetAllSamples(
"NewTabPage.SuggestionsImpression.IconsReal"),
ElementsAre(base::Bucket(/*min=*/0, /*count=*/1),
@@ -123,12 +117,6 @@ TEST(RecordPageImpressionTest, ShouldRecordUmaForThumbnails) {
IsEmpty());
EXPECT_THAT(histogram_tester.GetAllSamples("NewTabPage.TileType.popular"),
IsEmpty());
- EXPECT_THAT(histogram_tester.GetAllSamples("NewTabPage.IconsReal"),
- IsEmpty());
- EXPECT_THAT(histogram_tester.GetAllSamples("NewTabPage.IconsColor"),
- IsEmpty());
- EXPECT_THAT(histogram_tester.GetAllSamples("NewTabPage.IconsGray"),
- IsEmpty());
EXPECT_THAT(histogram_tester.GetAllSamples(
"NewTabPage.SuggestionsImpression.IconsReal"),
IsEmpty());
« no previous file with comments | « components/ntp_tiles/metrics.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698