Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Unified Diff: components/ntp_tiles/metrics.cc

Issue 2785183002: Remove histograms NewTabPage.IconsReal/IconsColor/IconsGray (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/ntp_tiles/metrics_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/ntp_tiles/metrics.cc
diff --git a/components/ntp_tiles/metrics.cc b/components/ntp_tiles/metrics.cc
index 4acc1c0d5c5fed99bf1db596d246579ac0be8581..a2139ae338be27f3c8bb7560d50dab5b7e5af811 100644
--- a/components/ntp_tiles/metrics.cc
+++ b/components/ntp_tiles/metrics.cc
@@ -82,8 +82,6 @@ void RecordPageImpression(const std::vector<TileImpression>& tiles,
rappor::RapporService* rappor_service) {
UMA_HISTOGRAM_SPARSE_SLOWLY("NewTabPage.NumberOfTiles", tiles.size());
- int counts_per_type[NUM_RECORDED_TILE_TYPES] = {0};
- bool have_tile_types = false;
for (int index = 0; index < static_cast<int>(tiles.size()); index++) {
NTPTileSource source = tiles[index].source;
MostVisitedTileType tile_type = tiles[index].type;
@@ -101,9 +99,6 @@ void RecordPageImpression(const std::vector<TileImpression>& tiles,
continue;
}
- have_tile_types = true;
- ++counts_per_type[tile_type];
-
UMA_HISTOGRAM_ENUMERATION("NewTabPage.TileType", tile_type,
NUM_RECORDED_TILE_TYPES);
@@ -123,15 +118,6 @@ void RecordPageImpression(const std::vector<TileImpression>& tiles,
LogHistogramEvent(icon_impression_histogram, index, kMaxNumTiles);
}
}
-
- if (have_tile_types) {
- UMA_HISTOGRAM_SPARSE_SLOWLY("NewTabPage.IconsReal",
- counts_per_type[ICON_REAL]);
- UMA_HISTOGRAM_SPARSE_SLOWLY("NewTabPage.IconsColor",
- counts_per_type[ICON_COLOR]);
- UMA_HISTOGRAM_SPARSE_SLOWLY("NewTabPage.IconsGray",
- counts_per_type[ICON_DEFAULT]);
- }
}
void RecordTileClick(int index,
« no previous file with comments | « no previous file | components/ntp_tiles/metrics_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698