Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 2784793002: [builtins] Extract builtin definitions (Closed)

Created:
3 years, 8 months ago by jgruber
Modified:
3 years, 8 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com, Benedikt Meurer, Igor Sheludko
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] Extract builtin definitions Move builtin definitions (i.e. BUILTIN_LIST and family) to a separate header in preparation for auto-generation of TFS interface descriptors. BUG=v8:6116 Review-Url: https://codereview.chromium.org/2784793002 Cr-Commit-Position: refs/heads/master@{#44221} Committed: https://chromium.googlesource.com/v8/v8/+/ac67a8cd1a58383aa1892030cd56f170b226a24a

Patch Set 1 #

Patch Set 2 : Fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1098 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M src/builtins/builtins.h View 2 chunks +1 line, -952 lines 0 comments Download
A + src/builtins/builtins-definitions.h View 1 2 chunks +4 lines, -144 lines 0 comments Download
M src/counters.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/counters.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects.h View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/v8.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (9 generated)
jgruber
3 years, 8 months ago (2017-03-29 09:30:22 UTC) #6
Yang
On 2017/03/29 09:30:22, jgruber wrote: lgtm.
3 years, 8 months ago (2017-03-29 09:31:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2784793002/20001
3 years, 8 months ago (2017-03-29 09:54:34 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 09:56:16 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/ac67a8cd1a58383aa1892030cd56f170b22...

Powered by Google App Engine
This is Rietveld 408576698