Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: src/builtins/builtins-definitions.h

Issue 2784793002: [builtins] Extract builtin definitions (Closed)
Patch Set: Fixes Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/builtins/builtins.h ('k') | src/counters.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/builtins/builtins-definitions.h
diff --git a/src/builtins/builtins.h b/src/builtins/builtins-definitions.h
similarity index 93%
copy from src/builtins/builtins.h
copy to src/builtins/builtins-definitions.h
index a3d3d746910a05905d2a9f03239f72f12b83e833..0f457e9a72e8c07093be5e48aa35a6c63b69eb0a 100644
--- a/src/builtins/builtins.h
+++ b/src/builtins/builtins-definitions.h
@@ -1,21 +1,13 @@
-// Copyright 2011 the V8 project authors. All rights reserved.
+// Copyright 2017 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef V8_BUILTINS_BUILTINS_H_
-#define V8_BUILTINS_BUILTINS_H_
-
-#include "src/base/flags.h"
-#include "src/globals.h"
+#ifndef V8_BUILTINS_BUILTINS_DEFINITIONS_H_
+#define V8_BUILTINS_BUILTINS_DEFINITIONS_H_
namespace v8 {
namespace internal {
-class Callable;
-template <typename T>
-class Handle;
-class Isolate;
-
#define CODE_AGE_LIST_WITH_ARG(V, A) \
V(Quadragenarian, A) \
V(Quinquagenarian, A) \
@@ -968,139 +960,7 @@ class Isolate;
#define BUILTINS_WITH_UNTAGGED_PARAMS(V) V(WasmCompileLazy)
-// Forward declarations.
-class ObjectVisitor;
-enum class InterpreterPushArgsMode : unsigned;
-namespace compiler {
-class CodeAssemblerState;
-}
-
-class Builtins {
- public:
- ~Builtins();
-
- // Generate all builtin code objects. Should be called once during
- // isolate initialization.
- void SetUp(Isolate* isolate, bool create_heap_objects);
- void TearDown();
-
- // Garbage collection support.
- void IterateBuiltins(ObjectVisitor* v);
-
- // Disassembler support.
- const char* Lookup(byte* pc);
-
- enum Name : int32_t {
-#define DEF_ENUM(Name, ...) k##Name,
- BUILTIN_LIST_ALL(DEF_ENUM)
-#undef DEF_ENUM
- builtin_count
- };
-
-#define DECLARE_BUILTIN_ACCESSOR(Name, ...) \
- V8_EXPORT_PRIVATE Handle<Code> Name();
- BUILTIN_LIST_ALL(DECLARE_BUILTIN_ACCESSOR)
-#undef DECLARE_BUILTIN_ACCESSOR
-
- // Convenience wrappers.
- Handle<Code> CallFunction(
- ConvertReceiverMode = ConvertReceiverMode::kAny,
- TailCallMode tail_call_mode = TailCallMode::kDisallow);
- Handle<Code> Call(ConvertReceiverMode = ConvertReceiverMode::kAny,
- TailCallMode tail_call_mode = TailCallMode::kDisallow);
- Handle<Code> CallBoundFunction(TailCallMode tail_call_mode);
- Handle<Code> NonPrimitiveToPrimitive(
- ToPrimitiveHint hint = ToPrimitiveHint::kDefault);
- Handle<Code> OrdinaryToPrimitive(OrdinaryToPrimitiveHint hint);
- Handle<Code> InterpreterPushArgsAndCall(TailCallMode tail_call_mode,
- InterpreterPushArgsMode mode);
- Handle<Code> InterpreterPushArgsAndConstruct(InterpreterPushArgsMode mode);
- Handle<Code> NewFunctionContext(ScopeType scope_type);
- Handle<Code> NewCloneShallowArray(AllocationSiteMode allocation_mode);
- Handle<Code> NewCloneShallowObject(int length);
-
- Code* builtin(Name name) {
- // Code::cast cannot be used here since we access builtins
- // during the marking phase of mark sweep. See IC::Clear.
- return reinterpret_cast<Code*>(builtins_[name]);
- }
-
- Address builtin_address(Name name) {
- return reinterpret_cast<Address>(&builtins_[name]);
- }
-
- static Callable CallableFor(Isolate* isolate, Name name);
-
- static const char* name(int index);
-
- // Returns the C++ entry point for builtins implemented in C++, and the null
- // Address otherwise.
- static Address CppEntryOf(int index);
-
- static bool IsCpp(int index);
- static bool IsApi(int index);
- static bool HasCppImplementation(int index);
-
- bool is_initialized() const { return initialized_; }
-
- MUST_USE_RESULT static MaybeHandle<Object> InvokeApiFunction(
- Isolate* isolate, bool is_construct, Handle<HeapObject> function,
- Handle<Object> receiver, int argc, Handle<Object> args[],
- Handle<HeapObject> new_target);
-
- enum ExitFrameType { EXIT, BUILTIN_EXIT };
-
- static void Generate_Adaptor(MacroAssembler* masm, Address builtin_address,
- ExitFrameType exit_frame_type);
-
- static bool AllowDynamicFunction(Isolate* isolate, Handle<JSFunction> target,
- Handle<JSObject> target_global_proxy);
-
- private:
- Builtins();
-
- static void Generate_CallFunction(MacroAssembler* masm,
- ConvertReceiverMode mode,
- TailCallMode tail_call_mode);
-
- static void Generate_CallBoundFunctionImpl(MacroAssembler* masm,
- TailCallMode tail_call_mode);
-
- static void Generate_Call(MacroAssembler* masm, ConvertReceiverMode mode,
- TailCallMode tail_call_mode);
- static void Generate_CallForwardVarargs(MacroAssembler* masm,
- Handle<Code> code);
-
- static void Generate_InterpreterPushArgsAndCallImpl(
- MacroAssembler* masm, TailCallMode tail_call_mode,
- InterpreterPushArgsMode mode);
-
- static void Generate_InterpreterPushArgsAndConstructImpl(
- MacroAssembler* masm, InterpreterPushArgsMode mode);
-
-#define DECLARE_ASM(Name, ...) \
- static void Generate_##Name(MacroAssembler* masm);
-#define DECLARE_TF(Name, ...) \
- static void Generate_##Name(compiler::CodeAssemblerState* state);
-
- BUILTIN_LIST(IGNORE_BUILTIN, IGNORE_BUILTIN, DECLARE_TF, DECLARE_TF,
- DECLARE_TF, DECLARE_ASM, DECLARE_ASM)
-
-#undef DECLARE_ASM
-#undef DECLARE_TF
-
- // Note: These are always Code objects, but to conform with
- // IterateBuiltins() above which assumes Object**'s for the callback
- // function f, we use an Object* array here.
- Object* builtins_[builtin_count];
- bool initialized_;
-
- friend class Isolate;
-
- DISALLOW_COPY_AND_ASSIGN(Builtins);
-};
-
} // namespace internal
} // namespace v8
-#endif // V8_BUILTINS_BUILTINS_H_
+#endif // V8_BUILTINS_BUILTINS_DEFINITIONS_H_
« no previous file with comments | « src/builtins/builtins.h ('k') | src/counters.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698